Summary

Expand issue comment parent box

Review Request #4625 — Created Sept. 21, 2013 and submitted Sept. 21, 2013, 2:01 p.m.

Information

Owner

medanat

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Clicking on an issue in the issue summary table will now navigate the user to the issue comment and expand the parent box if it is collapsed.

Testing Done

Issues

Description	From	Last Updated
_ before this, since nothing outside this class should call it.	chipx86	Sept. 21, 2013, 1:21 p.m.
Should just be /*	chipx86	Sept. 21, 2013, 1:21 p.m.
$el is more standard for our codebase.	chipx86	Sept. 21, 2013, 1:21 p.m.
Looking at this again, I think issueClicked should instead pass the comment type and issue-id as parameters, and leave the …	chipx86	Sept. 21, 2013, 1:21 p.m.
Blank line should be removed.	chipx86	Sept. 21, 2013, 1:21 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/issueSummaryTableView.js
reviewboard/static/rb/js/pages/views/reviewRequestPageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/issueSummaryTableView.js
reviewboard/static/rb/js/pages/views/reviewRequestPageView.js

reviewboard/static/rb/js/pages/views/reviewRequestPageView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
_ before this, since nothing outside this class should call it.
```
reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Should just be /*
```
reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
$el is more standard for our codebase.
```

reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1)

The issue has been resolved. Show all issues

Looking at this again, I think issueClicked should instead pass the comment type and issue-id as parameters, and leave the selector name creation to the part that expands the box. The issue summary view doesn't need to know the format of those IDs.

reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line should be removed.
```

Change Summary:

Fix issues based on review.

Diff:

Revision 2 (+35 -7)

Show changes

	reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
	reviewboard/static/rb/js/views/issueSummaryTableView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/issueSummaryTableView.js
reviewboard/static/rb/js/pages/views/reviewRequestPageView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (c14122b)