Expand issue comment parent box
Review Request #4625 — Created Sept. 21, 2013 and submitted
Clicking on an issue in the issue summary table will now navigate the user to the issue comment and expand the parent box if it is collapsed.
| Description | From | Last Updated |
|---|---|---|
|
_ before this, since nothing outside this class should call it. |
 chipx86
|
|
|
Should just be /* |
chipx86
|
|
|
$el is more standard for our codebase. |
chipx86
|
|
|
Looking at this again, I think issueClicked should instead pass the comment type and issue-id as parameters, and leave the … |
chipx86
|
|
|
Blank line should be removed. |
chipx86
|
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/issueSummaryTableView.js
reviewboard/static/rb/js/pages/views/reviewRequestPageView.js
-
-
reviewboard/static/rb/js/pages/views/reviewRequestPageView.js (Diff revision 1) _ before this, since nothing outside this class should call it.
-
-
reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1) $el is more standard for our codebase.
-
reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1) Looking at this again, I think issueClicked should instead pass the comment type and issue-id as parameters, and leave the selector name creation to the part that expands the box. The issue summary view doesn't need to know the format of those IDs.
-
reviewboard/static/rb/js/views/issueSummaryTableView.js (Diff revision 1) Blank line should be removed.
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/issueSummaryTableView.js
reviewboard/static/rb/js/pages/views/reviewRequestPageView.js