Summary

Add new hook points for adding entries to the header

Review Request #4624 — Created Sept. 21, 2013 and submitted Sept. 22, 2013, 1:30 p.m.

Information

Owner

mike_conley

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add HeaderActionHook and HeaderDropdownActionHook for putting items into the base page header (where the branding, search, account management and support links are).

Testing Done

Wrote some unit tests, and did manual testing with my TogetherJS extension.

Files

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:57 a.m.
Col: 66 W292 no newline at end of file	reviewbot	Sept. 22, 2013, 6:57 a.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Sept. 22, 2013, 6:59 a.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Sept. 22, 2013, 6:59 a.m.
Col: 1 W391 blank line at end of file	reviewbot	Sept. 22, 2013, 6:59 a.m.
Collapse these down to one load statement. It's faster.	chipx86	Sept. 22, 2013, 7:16 a.m.
Trailing newline.	chipx86	Sept. 22, 2013, 7:16 a.m.
Whoops - the comments that Christian brought up were for this file, not action_dropdown.html. Let me fix that.	mike_conley	Sept. 22, 2013, 7:28 a.m.
Indentation for template tags should go inside the {% .. %}, so: {% for action ... %} {% include ... …	chipx86	Sept. 22, 2013, 7:56 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 66

 W292 no newline at end of file
```
reviewboard/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5

 E303 too many blank lines (2)
```
reviewboard/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5

 E303 too many blank lines (2)
```
reviewboard/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1

 W391 blank line at end of file
```

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

reviewboard/templates/extensions/header_action_dropdown.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Collapse these down to one load statement. It's faster.
```
reviewboard/templates/extensions/header_action_dropdown.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing newline.
```

Change Summary:: Adding a screenshot for clarity.
Added Files:

Change Summary:

Fixed the reported issues.

Diff:

Revision 2 (+88 -33)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py
	reviewboard/templates/base.html
	reviewboard/templates/extensions/action_dropdown.html
	reviewboard/templates/extensions/header_action_dropdown.html

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/action_dropdown.html
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/action_dropdown.html
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

reviewboard/templates/extensions/header_action_dropdown.html (Diff revision 2)

The issue has been resolved. Show all issues

Whoops - the comments that Christian brought up were for this file, not action_dropdown.html. Let me fix that.

Diff:

Revision 3 (+84 -33)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py
	reviewboard/templates/base.html
	reviewboard/templates/extensions/action_dropdown.html
	reviewboard/templates/extensions/header_action_dropdown.html

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/action_dropdown.html
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/action_dropdown.html
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

reviewboard/templates/extensions/action_dropdown.html (Diff revision 3)

I decided to keep this accidental change since it's ultimately faster to load things this way.

reviewboard/templates/extensions/header_action_dropdown.html (Diff revision 3)

The issue has been resolved. Show all issues

Indentation for template tags should go inside the {% .. %}, so:
{% for action ... %}
{%  include ... %}
{% endfor %}

Change Summary:

Fixing indentation issues.

Diff:

Revision 4 (+85 -34)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py
	reviewboard/templates/base.html
	reviewboard/templates/extensions/action_dropdown.html
	reviewboard/templates/extensions/header_action_dropdown.html

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/action_dropdown.html
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/extensions/templatetags/rb_extensions.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests.py
Ignored Files:
reviewboard/templates/extensions/action_dropdown.html
reviewboard/templates/extensions/header_action_dropdown.html
reviewboard/templates/base.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Landed as 33ed256007. Thanks!