Add quotes to {% url %} tags.

Review Request #4619 — Created Sept. 21, 2013 and submitted

Information

Review Board
master

Reviewers

Add quotes to {% url %} tags.

The url templatetag has been changed to require quotes around string arguments
(like everything else does). Update our templates accordingly.

  • Ran unit tests.
  • Grepped for "url" in all our templates.
Description From Last Updated

'templatetags' imported but unused

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/site/tests.py
    Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/templates/reviews/user_page.html
    reviewboard/templates/reviews/ui/base.html
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/base.html
    reviewboard/templates/accounts/password_reset_confirm.html
    reviewboard/templates/404.html
    reviewboard/templates/accounts/password_reset_complete.html
    reviewboard/templates/diffviewer/diff_file_fragment.html
    reviewboard/templates/reviews/review_request_box.html
    reviewboard/templates/admin/repository_confirmations.html
    reviewboard/templates/reviews/dashboard_entry.html
    reviewboard/templates/diffviewer/diff_fragment_error.html
    reviewboard/templates/reviews/review_issue_summary_table.html
    reviewboard/templates/admin/base_site.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/templates/notifications/review_request_email.txt
    reviewboard/templates/accounts/login.html
    reviewboard/templates/accounts/password_reset_email.txt
    reviewboard/templates/base/branding.html

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/site/tests.py
    Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/templates/reviews/user_page.html
    reviewboard/templates/reviews/ui/base.html
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/base.html
    reviewboard/templates/accounts/password_reset_confirm.html
    reviewboard/templates/404.html
    reviewboard/templates/accounts/password_reset_complete.html
    reviewboard/templates/diffviewer/diff_file_fragment.html
    reviewboard/templates/reviews/review_request_box.html
    reviewboard/templates/admin/repository_confirmations.html
    reviewboard/templates/reviews/dashboard_entry.html
    reviewboard/templates/diffviewer/diff_fragment_error.html
    reviewboard/templates/reviews/review_issue_summary_table.html
    reviewboard/templates/admin/base_site.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/templates/notifications/review_request_email.txt
    reviewboard/templates/accounts/login.html
    reviewboard/templates/accounts/password_reset_email.txt
    reviewboard/templates/base/branding.html

  2. reviewboard/site/tests.py (Diff revision 1)
     
     
    Show all issues

    'templatetags' imported but unused

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:

Pushed to master (a0f4b23).