Summary

Bump setuptools version to 0.6c11, which is the one available on the PyPi

Review Request #4617 — Created Sept. 21, 2013 and submitted Sept. 22, 2013, 6:51 a.m.

Information

Owner

mike_conley

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Bump setuptools version to 0.6c11, which is the one available on the PyPi

Testing Done

None - wasn't sure how best to test this...

Issues

Description	From	Last Updated
undefined name 'pkg_resources'	reviewbot	Sept. 21, 2013, 10:57 a.m.
'shutil' imported but unused	reviewbot	Sept. 21, 2013, 10:57 a.m.
Col: 4 E701 multiple statements on one line (colon)	reviewbot	Sept. 21, 2013, 10:59 a.m.
Col: 19 E701 multiple statements on one line (colon)	reviewbot	Sept. 21, 2013, 10:59 a.m.
'shutil' imported but unused	reviewbot	Sept. 21, 2013, 10:59 a.m.
Col: 1 W391 blank line at end of file	reviewbot	Sept. 21, 2013, 10:59 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 13 E122 continuation line missing indentation or outdented	reviewbot	Sept. 22, 2013, 6:42 a.m.
undefined name 'pkg_resources'	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:42 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Sept. 22, 2013, 6:43 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Sept. 22, 2013, 6:43 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
ez_setup.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
ez_setup.py
Ignored Files:

ez_setup.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'pkg_resources'
```
ez_setup.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'shutil' imported but unused
```

When I ran easy_install -U setuptools, it grabbed 1.1.6. Thinking we should just grab the ez_setup.py from that.

It'll be important to grab that instead of patching due to the checksums.

Change Summary:

I think this is the authoritative ez_setup.py:

http://peak.telecommunity.com/dist/ez_setup.py

And that's what I've dropped in. Better?

Diff:

Revision 2 (+20 -8)

Show changes

ez_setup.py

Fix it!

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
ez_setup.py
Ignored Files:

ez_setup.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 4

 E701 multiple statements on one line (colon)
```

ez_setup.py (Diff revision 2)

An issue was opened. Show all issues

Col: 19

 E701 multiple statements on one line (colon)

ez_setup.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 1

 W391 blank line at end of file
```

Fix it!

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
ez_setup.py
Ignored Files:

ez_setup.py (Diff revision 2)
An issue was opened. Show all issues
```
'shutil' imported but unused
```

Change Summary:

So apparently, telecommunity's page hasn't been updated since 2007. Ownership of setuptools moved elsewhere, and I think this links to the authoritative ez_setup.py.

Diff:

Revision 3 (+329 -231)

Show changes

ez_setup.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
ez_setup.py
Ignored Files:

ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 5

 E301 expected 1 blank line, found 0
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```

ez_setup.py (Diff revision 3)

The issue has been dropped. Show all issues

Col: 13
E122 continuation line missing indentation or outdented

ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (87 > 79 characters)
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```
ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1

 E302 expected 2 blank lines, found 1
```

ez_setup.py (Diff revision 3)

The issue has been dropped. Show all issues

Col: 9
E128 continuation line under-indented for visual indent

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
ez_setup.py
Ignored Files:

ez_setup.py (Diff revision 3)
The issue has been dropped. Show all issues
```
undefined name 'pkg_resources'
```

Ship it!

```
Haha, Review Bot is so mad.
```

Status: Closed (submitted)

Change Summary:

Landed as e271b84ebf. Thanks for the review!