Don't show "Show changes" when there is only one diff revision

Review Request #4613 — Created Sept. 21, 2013 and submitted

bzd
Review Board
master
2901
reviewboard

Don't show "Show changes" when there is only one diff revision

Added logic to review_detail.html so that if the past revision number of a diff is 0 (a diff has been added after a review request has been published) a "Show changes" link would not be displayed.

Reproduced the bug by publishing a review request, then adding a diff and verifying that the "Show changes" link does not appear. Added a second diff to the same review request and verified that the "Show changes" link does appear as it should for the second diff.

reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    reviewboard/templates/reviews/review_detail.html

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    reviewboard/templates/reviews/review_detail.html

  2. 
      
david
  1. Ship It!

  2. 
      
BZ
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (f53190b). Thanks!

Loading...