Increased z-index on modal-box to stop obstruction from user-account-nav dropdowns

Review Request #4607 — Created Sept. 20, 2013 and submitted

Information

Djblets
master

Reviewers

Increased z-index on modal-box to stop obstruction from user-account-nav dropdowns

clicked on a review request, hit review which brought up the modal screen and ensured that the usernav drop down was no longer visible over the modal box.

Description From Last Updated

Maybe store the value 2000 in a variable, that way its easier to reference and change later on. However, it …

ME medanat
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    djblets/media/js/jquery.gravy.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    djblets/media/js/jquery.gravy.js

  2. 
      
ME
  1. 
      
  2. djblets/media/js/jquery.gravy.js (Diff revision 1)
     
     

    Maybe store the value 2000 in a variable, that way its easier to reference and change later on.

    However, it seems that all the z-indexes are passed by value around gravy, so maybe don't worry about it.

    I'm guessing it would be nice if all z-indexes were stored in descriptive variables, making it much easier to maintain. Someone else can chime in on this.

  3. 
      
david
  1. Ship It!

  2. 
      
EN
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (da847a2).

Loading...