Summary

Move diff pagination into javascript.

Review Request #4603 — Created Sept. 20, 2013 and submitted Sept. 21, 2013, 10:14 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Move diff pagination into javascript.

The pagination selector is pretty ugly and terrible at this point, and we'll
probably redesign this later, but for now, I'd like to keep it as-is but allow
it to update dynamically so we can load different revisions. This change moves
its rendering into javascript.

Testing Done

Set up a few different revisions with different pagination. Checked that the
pagination selector rendered appropriately in different cases, and that the
different links went to the right pages.

Issues

Description	From	Last Updated
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 20, 2013, 7:24 a.m.
Can't this just be <%- interpolate(...) %> ?	chipx86	Sept. 20, 2013, 11:36 a.m.
Extra blank line.	chipx86	Sept. 20, 2013, 11:37 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 20, 2013, 11:40 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/models/paginationModel.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js
reviewboard/static/rb/js/diffviewer/views/paginationView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/models/paginationModel.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js
reviewboard/static/rb/js/diffviewer/views/paginationView.js

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

reviewboard/static/rb/js/diffviewer/views/paginationView.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Can't this just be <%- interpolate(...) %> ?
```
1. david Sept. 20, 2013, 11:37 a.m.
  Nope, <%- %> is only for interpolating variables, not for calling javascript.
reviewboard/static/rb/js/diffviewer/views/paginationView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra blank line.
```

Diff:

Revision 2 (+97 -14)

Show changes

	reviewboard/settings.py
	reviewboard/static/rb/js/diffviewer/models/paginationModel.js
	reviewboard/static/rb/js/diffviewer/views/paginationView.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.js
	reviewboard/templates/diffviewer/view_diff.html

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (6d4fa08).

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)