Simplify the webapi test function names.

Review Request #4602 — Created Sept. 20, 2013 and submitted

Information

Review Board
master

Reviewers

Simplify the webapi test function names.

This removes all the redundancy in the test function names, in order to
shorten them. The type of resource has been removed from the names. So,
instead of test_get_file_attachment_with_foo, it's just
test_get_with_foo.

Unit tests pass.

Description From Last Updated

'FileAttachment' imported but unused

reviewbotreviewbot

redefinition of unused '_common_post_interdiff_comments' from line 16

reviewbotreviewbot

redefinition of unused '_create_diff_review_with_issue' from line 30

reviewbotreviewbot

redefinition of unused '_create_diff_review_request' from line 50

reviewbotreviewbot

redefinition of unused '_create_diff_review' from line 61

reviewbotreviewbot

local variable 'reply' is assigned to but never used

reviewbotreviewbot

'User' imported but unused

reviewbotreviewbot

'LocalSite' imported but unused

reviewbotreviewbot

'review_reply_diff_comment_list_mimetype' imported but unused

reviewbotreviewbot

'User' imported but unused

reviewbotreviewbot

'LocalSite' imported but unused

reviewbotreviewbot

'review_reply_file_attachment_comment_list_mimetype' imported but unused

reviewbotreviewbot

'User' imported but unused

reviewbotreviewbot

'LocalSite' imported but unused

reviewbotreviewbot

'review_reply_screenshot_comment_list_mimetype' imported but unused

reviewbotreviewbot

'User' imported but unused

reviewbotreviewbot

'User' imported but unused

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/test_server_info.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/test_screenshot_comment.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_repository_info.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/test_server_info.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/test_screenshot_comment.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_repository_info.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    Ignored Files:

  2. 'FileAttachment' imported but unused

  3. redefinition of unused '_common_post_interdiff_comments' from line 16

  4. redefinition of unused '_create_diff_review_with_issue' from line 30

  5. redefinition of unused '_create_diff_review_request' from line 50

  6. redefinition of unused '_create_diff_review' from line 61

  7. local variable 'reply' is assigned to but never used

  8. 'User' imported but unused

  9. 'LocalSite' imported but unused

  10. 'review_reply_diff_comment_list_mimetype' imported but unused

  11. 'LocalSite' imported but unused

  12. 'review_reply_file_attachment_comment_list_mimetype' imported but unused

  13. 'User' imported but unused

  14. 'LocalSite' imported but unused

  15. 'review_reply_screenshot_comment_list_mimetype' imported but unused

  16. 'User' imported but unused

  17. 'User' imported but unused

  18. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/test_server_info.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/test_screenshot_comment.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_repository_info.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/test_server_info.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/test_screenshot_comment.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_repository_info.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    Ignored Files:

  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...