Summary

Change django.utils.simplejson to json.

Review Request #4601 — Created Sept. 20, 2013 and submitted Sept. 20, 2013, 11:52 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Change django.utils.simplejson to json.

Django 1.5 deprecates the use of the bundled simplejson, because Python 2.6's
json module includes everything that's needed.

Testing Done

Ran unit tests

Issues

Description	From	Last Updated
list comprehension redefines 'template_name' from line 100	reviewbot	Sept. 20, 2013, 7:09 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/hostingsvcs/beanstalk.py
reviewboard/admin/views.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/hostingsvcs/bitbucket.py
reviewboard/hostingsvcs/service.py
reviewboard/hostingsvcs/github.py
reviewboard/webapi/tests/base.py
reviewboard/reviews/ui/base.py
reviewboard/hostingsvcs/tests.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/hostingsvcs/beanstalk.py
reviewboard/admin/views.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/hostingsvcs/bitbucket.py
reviewboard/hostingsvcs/service.py
reviewboard/hostingsvcs/github.py
reviewboard/webapi/tests/base.py
reviewboard/reviews/ui/base.py
reviewboard/hostingsvcs/tests.py
Ignored Files:

reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
list comprehension redefines 'template_name' from line 100
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (071aade).

reviewboard/admin/views.py (Diff revision 1)