Change django.utils.simplejson to json.

Review Request #4601 — Created Sept. 20, 2013 and submitted

Information

Review Board
master

Reviewers

Change django.utils.simplejson to json.

Django 1.5 deprecates the use of the bundled simplejson, because Python 2.6's
json module includes everything that's needed.

Ran unit tests

Description From Last Updated

list comprehension redefines 'template_name' from line 100

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/hostingsvcs/beanstalk.py
    reviewboard/admin/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/hostingsvcs/bitbucket.py
    reviewboard/hostingsvcs/service.py
    reviewboard/hostingsvcs/github.py
    reviewboard/webapi/tests/base.py
    reviewboard/reviews/ui/base.py
    reviewboard/hostingsvcs/tests.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/hostingsvcs/beanstalk.py
    reviewboard/admin/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/hostingsvcs/bitbucket.py
    reviewboard/hostingsvcs/service.py
    reviewboard/hostingsvcs/github.py
    reviewboard/webapi/tests/base.py
    reviewboard/reviews/ui/base.py
    reviewboard/hostingsvcs/tests.py
    Ignored Files:

  2. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    list comprehension redefines 'template_name' from line 100

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:

Pushed to master (071aade).