Summary:

Update perforce SCMTool to use p4python 08.1 API.

Review Request #460 — Created July 23, 2008 and submitted

Information
Owner:	david
Repository:	Review Board SVN (deprecated)
Branch:	trunk
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

As of the 08.1 API release, the p4python wrapper is now an officially supported
product from Perforce.  This is awesome, but they changed things up a bit
(entirely for the better -- parsing changesets is quite a bit simpler now).
This change updates our perforce tool to use the new API.

Testing Done

This code has been running on reviewboard.eng since they upgraded our main
perforce server a couple months ago.

/trunk/reviewboard/manage.py (Diff revision 1)

Is this correct? $4?

david July 23, 2008, 6:16 a.m.

Haha, nope.  That's what I get for transcribing the changes onto my laptop.

/trunk/reviewboard/scmtools/perforce.py (Diff revision 1)

I ran into a bug with this on our VMware server. If the changeset does not exist, this throws an exception. I suggest:

if changeset:
   return self.parse_change_desc(...)

return None

david July 23, 2008, 6:17 a.m.
```
Okay.
```

Ship it!

```
Looks good.
```