Split the API test suites into Item and List classes.
Review Request #4599 — Created Sept. 20, 2013 and submitted
Split the API test suites into Item and List classes.
For organizational purposes, and to make it easy to select a particular
set of tests, the API test classes have been split into two. There are
now resource list tests in each test file (all named ResourceListTests),
and item tests (ResourceItemTests). By keeping the same name, there's no
guesswork. It's easy to just run a set of tests in a resource's test
file.While in here, I removed some usage of test_scmtools from the new
classes, which were not really needed.
Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
'FileAttachment' imported but unused |
 reviewbot
|
|
|
redefinition of unused '_common_post_interdiff_comments' from line 16 |
reviewbot
|
|
|
redefinition of unused '_create_diff_review_with_issue' from line 30 |
reviewbot
|
|
|
redefinition of unused '_create_diff_review_request' from line 50 |
reviewbot
|
|
|
redefinition of unused '_create_diff_review' from line 61 |
reviewbot
|
|
|
local variable 'reply' is assigned to but never used |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'LocalSite' imported but unused |
reviewbot
|
|
|
'review_reply_diff_comment_list_mimetype' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'LocalSite' imported but unused |
reviewbot
|
|
|
'review_reply_file_attachment_comment_list_mimetype' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'LocalSite' imported but unused |
reviewbot
|
|
|
'review_reply_screenshot_comment_list_mimetype' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_default_reviewer.py
reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
reviewboard/webapi/tests/test_screenshot.py
reviewboard/webapi/tests/test_screenshot_draft.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_group.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_change.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_server_info.py
reviewboard/webapi/tests/test_repository_branches.py
reviewboard/webapi/tests/test_user.py
reviewboard/webapi/tests/test_screenshot_comment.py
reviewboard/webapi/tests/test_session.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
reviewboard/webapi/tests/test_diff.py
reviewboard/webapi/tests/test_repository.py
reviewboard/webapi/tests/test_validate_diff.py
reviewboard/webapi/tests/test_root.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_review_group_user.py
reviewboard/webapi/tests/test_repository_info.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
Ignored Files: -
reviewboard/webapi/tests/test_file_attachment.py (Diff revision 1) 'FileAttachment' imported but unused
-
reviewboard/webapi/tests/test_review_comment.py (Diff revision 1) redefinition of unused '_common_post_interdiff_comments' from line 16
-
reviewboard/webapi/tests/test_review_comment.py (Diff revision 1) redefinition of unused '_create_diff_review_with_issue' from line 30
-
reviewboard/webapi/tests/test_review_comment.py (Diff revision 1) redefinition of unused '_create_diff_review_request' from line 50
-
reviewboard/webapi/tests/test_review_comment.py (Diff revision 1) redefinition of unused '_create_diff_review' from line 61
-
reviewboard/webapi/tests/test_review_reply.py (Diff revision 1) local variable 'reply' is assigned to but never used
-
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1) 'User' imported but unused
-
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1) 'LocalSite' imported but unused
-
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1) 'review_reply_diff_comment_list_mimetype' imported but unused
-
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1) 'User' imported but unused
-
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1) 'LocalSite' imported but unused
-
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1) 'review_reply_file_attachment_comment_list_mimetype' imported but unused
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1) 'User' imported but unused
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1) 'LocalSite' imported but unused
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1) 'review_reply_screenshot_comment_list_mimetype' imported but unused
-
-
reviewboard/webapi/tests/test_watched_review_request.py (Diff revision 1) 'User' imported but unused
Change Summary:
Updated against master to resolve the errors listed.
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_default_reviewer.py
reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
reviewboard/webapi/tests/test_screenshot.py
reviewboard/webapi/tests/test_screenshot_draft.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_group.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_change.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_server_info.py
reviewboard/webapi/tests/test_repository_branches.py
reviewboard/webapi/tests/test_user.py
reviewboard/webapi/tests/test_screenshot_comment.py
reviewboard/webapi/tests/test_session.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
reviewboard/webapi/tests/test_diff.py
reviewboard/webapi/tests/test_repository.py
reviewboard/webapi/tests/test_validate_diff.py
reviewboard/webapi/tests/test_root.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_review_group_user.py
reviewboard/webapi/tests/test_repository_info.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
Ignored Files:
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_default_reviewer.py
reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
reviewboard/webapi/tests/test_screenshot.py
reviewboard/webapi/tests/test_screenshot_draft.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_group.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_change.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_server_info.py
reviewboard/webapi/tests/test_repository_branches.py
reviewboard/webapi/tests/test_user.py
reviewboard/webapi/tests/test_screenshot_comment.py
reviewboard/webapi/tests/test_session.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
reviewboard/webapi/tests/test_diff.py
reviewboard/webapi/tests/test_repository.py
reviewboard/webapi/tests/test_validate_diff.py
reviewboard/webapi/tests/test_root.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_review_group_user.py
reviewboard/webapi/tests/test_repository_info.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
Ignored Files:
