• 
      

    Split the API test suites into Item and List classes.

    Review Request #4599 — Created Sept. 20, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Split the API test suites into Item and List classes.

    For organizational purposes, and to make it easy to select a particular
    set of tests, the API test classes have been split into two. There are
    now resource list tests in each test file (all named ResourceListTests),
    and item tests (ResourceItemTests). By keeping the same name, there's no
    guesswork. It's easy to just run a set of tests in a resource's test
    file.

    While in here, I removed some usage of test_scmtools from the new
    classes, which were not really needed.

    Unit tests pass.

    Description From Last Updated

    'FileAttachment' imported but unused

    reviewbot reviewbot

    redefinition of unused '_common_post_interdiff_comments' from line 16

    reviewbot reviewbot

    redefinition of unused '_create_diff_review_with_issue' from line 30

    reviewbot reviewbot

    redefinition of unused '_create_diff_review_request' from line 50

    reviewbot reviewbot

    redefinition of unused '_create_diff_review' from line 61

    reviewbot reviewbot

    local variable 'reply' is assigned to but never used

    reviewbot reviewbot

    'User' imported but unused

    reviewbot reviewbot

    'LocalSite' imported but unused

    reviewbot reviewbot

    'review_reply_diff_comment_list_mimetype' imported but unused

    reviewbot reviewbot

    'User' imported but unused

    reviewbot reviewbot

    'LocalSite' imported but unused

    reviewbot reviewbot

    'review_reply_file_attachment_comment_list_mimetype' imported but unused

    reviewbot reviewbot

    'User' imported but unused

    reviewbot reviewbot

    'LocalSite' imported but unused

    reviewbot reviewbot

    'review_reply_screenshot_comment_list_mimetype' imported but unused

    reviewbot reviewbot

    'User' imported but unused

    reviewbot reviewbot

    'User' imported but unused

    reviewbot reviewbot
    reviewbot
    1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
      reviewboard/webapi/tests/test_review_screenshot_comment.py
      reviewboard/webapi/tests/test_file_diff_comment.py
      reviewboard/webapi/tests/test_watched_review_request.py
      reviewboard/webapi/tests/test_review.py
      reviewboard/webapi/tests/test_default_reviewer.py
      reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
      reviewboard/webapi/tests/test_screenshot.py
      reviewboard/webapi/tests/test_screenshot_draft.py
      reviewboard/webapi/tests/test_review_comment.py
      reviewboard/webapi/tests/test_review_group.py
      reviewboard/webapi/tests/test_file_attachment_draft.py
      reviewboard/webapi/tests/test_change.py
      reviewboard/webapi/tests/test_review_reply.py
      reviewboard/webapi/tests/test_file_attachment_comment.py
      reviewboard/webapi/tests/test_server_info.py
      reviewboard/webapi/tests/test_repository_branches.py
      reviewboard/webapi/tests/test_user.py
      reviewboard/webapi/tests/test_screenshot_comment.py
      reviewboard/webapi/tests/test_session.py
      reviewboard/webapi/tests/test_watched_review_group.py
      reviewboard/webapi/tests/test_review_request.py
      reviewboard/webapi/tests/test_review_request_draft.py
      reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
      reviewboard/webapi/tests/test_diff.py
      reviewboard/webapi/tests/test_repository.py
      reviewboard/webapi/tests/test_validate_diff.py
      reviewboard/webapi/tests/test_root.py
      reviewboard/webapi/tests/test_file_attachment.py
      reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
      reviewboard/webapi/tests/test_review_group_user.py
      reviewboard/webapi/tests/test_repository_info.py
      reviewboard/webapi/tests/test_review_reply_diff_comment.py
      Ignored Files:

    2. 
        
    reviewbot
    1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
      reviewboard/webapi/tests/test_review_screenshot_comment.py
      reviewboard/webapi/tests/test_file_diff_comment.py
      reviewboard/webapi/tests/test_watched_review_request.py
      reviewboard/webapi/tests/test_review.py
      reviewboard/webapi/tests/test_default_reviewer.py
      reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
      reviewboard/webapi/tests/test_screenshot.py
      reviewboard/webapi/tests/test_screenshot_draft.py
      reviewboard/webapi/tests/test_review_comment.py
      reviewboard/webapi/tests/test_review_group.py
      reviewboard/webapi/tests/test_file_attachment_draft.py
      reviewboard/webapi/tests/test_change.py
      reviewboard/webapi/tests/test_review_reply.py
      reviewboard/webapi/tests/test_file_attachment_comment.py
      reviewboard/webapi/tests/test_server_info.py
      reviewboard/webapi/tests/test_repository_branches.py
      reviewboard/webapi/tests/test_user.py
      reviewboard/webapi/tests/test_screenshot_comment.py
      reviewboard/webapi/tests/test_session.py
      reviewboard/webapi/tests/test_watched_review_group.py
      reviewboard/webapi/tests/test_review_request.py
      reviewboard/webapi/tests/test_review_request_draft.py
      reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
      reviewboard/webapi/tests/test_diff.py
      reviewboard/webapi/tests/test_repository.py
      reviewboard/webapi/tests/test_validate_diff.py
      reviewboard/webapi/tests/test_root.py
      reviewboard/webapi/tests/test_file_attachment.py
      reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
      reviewboard/webapi/tests/test_review_group_user.py
      reviewboard/webapi/tests/test_repository_info.py
      reviewboard/webapi/tests/test_review_reply_diff_comment.py
      Ignored Files:

    2. Show all issues

      'FileAttachment' imported but unused

    3. Show all issues

      redefinition of unused '_common_post_interdiff_comments' from line 16

    4. Show all issues

      redefinition of unused '_create_diff_review_with_issue' from line 30

    5. Show all issues

      redefinition of unused '_create_diff_review_request' from line 50

    6. Show all issues

      redefinition of unused '_create_diff_review' from line 61

    7. Show all issues

      local variable 'reply' is assigned to but never used

    8. Show all issues

      'User' imported but unused

    9. Show all issues

      'LocalSite' imported but unused

    10. Show all issues

      'review_reply_diff_comment_list_mimetype' imported but unused

    11. Show all issues

      'User' imported but unused

    12. Show all issues

      'LocalSite' imported but unused

    13. Show all issues

      'review_reply_file_attachment_comment_list_mimetype' imported but unused

    14. Show all issues

      'User' imported but unused

    15. Show all issues

      'LocalSite' imported but unused

    16. Show all issues

      'review_reply_screenshot_comment_list_mimetype' imported but unused

    17. Show all issues

      'User' imported but unused

    18. Show all issues

      'User' imported but unused

    19. 
        
    chipx86
    reviewbot
    1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
      reviewboard/webapi/tests/test_review_screenshot_comment.py
      reviewboard/webapi/tests/test_file_diff_comment.py
      reviewboard/webapi/tests/test_watched_review_request.py
      reviewboard/webapi/tests/test_review.py
      reviewboard/webapi/tests/test_default_reviewer.py
      reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
      reviewboard/webapi/tests/test_screenshot.py
      reviewboard/webapi/tests/test_screenshot_draft.py
      reviewboard/webapi/tests/test_review_comment.py
      reviewboard/webapi/tests/test_review_group.py
      reviewboard/webapi/tests/test_file_attachment_draft.py
      reviewboard/webapi/tests/test_change.py
      reviewboard/webapi/tests/test_review_reply.py
      reviewboard/webapi/tests/test_file_attachment_comment.py
      reviewboard/webapi/tests/test_server_info.py
      reviewboard/webapi/tests/test_repository_branches.py
      reviewboard/webapi/tests/test_user.py
      reviewboard/webapi/tests/test_screenshot_comment.py
      reviewboard/webapi/tests/test_session.py
      reviewboard/webapi/tests/test_watched_review_group.py
      reviewboard/webapi/tests/test_review_request.py
      reviewboard/webapi/tests/test_review_request_draft.py
      reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
      reviewboard/webapi/tests/test_diff.py
      reviewboard/webapi/tests/test_repository.py
      reviewboard/webapi/tests/test_validate_diff.py
      reviewboard/webapi/tests/test_root.py
      reviewboard/webapi/tests/test_file_attachment.py
      reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
      reviewboard/webapi/tests/test_review_group_user.py
      reviewboard/webapi/tests/test_repository_info.py
      reviewboard/webapi/tests/test_review_reply_diff_comment.py
      Ignored Files:

    2. 
        
    reviewbot
    1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
      reviewboard/webapi/tests/test_review_screenshot_comment.py
      reviewboard/webapi/tests/test_file_diff_comment.py
      reviewboard/webapi/tests/test_watched_review_request.py
      reviewboard/webapi/tests/test_review.py
      reviewboard/webapi/tests/test_default_reviewer.py
      reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
      reviewboard/webapi/tests/test_screenshot.py
      reviewboard/webapi/tests/test_screenshot_draft.py
      reviewboard/webapi/tests/test_review_comment.py
      reviewboard/webapi/tests/test_review_group.py
      reviewboard/webapi/tests/test_file_attachment_draft.py
      reviewboard/webapi/tests/test_change.py
      reviewboard/webapi/tests/test_review_reply.py
      reviewboard/webapi/tests/test_file_attachment_comment.py
      reviewboard/webapi/tests/test_server_info.py
      reviewboard/webapi/tests/test_repository_branches.py
      reviewboard/webapi/tests/test_user.py
      reviewboard/webapi/tests/test_screenshot_comment.py
      reviewboard/webapi/tests/test_session.py
      reviewboard/webapi/tests/test_watched_review_group.py
      reviewboard/webapi/tests/test_review_request.py
      reviewboard/webapi/tests/test_review_request_draft.py
      reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
      reviewboard/webapi/tests/test_diff.py
      reviewboard/webapi/tests/test_repository.py
      reviewboard/webapi/tests/test_validate_diff.py
      reviewboard/webapi/tests/test_root.py
      reviewboard/webapi/tests/test_file_attachment.py
      reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
      reviewboard/webapi/tests/test_review_group_user.py
      reviewboard/webapi/tests/test_repository_info.py
      reviewboard/webapi/tests/test_review_reply_diff_comment.py
      Ignored Files:

    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed