Speed up the tests further, and remove interdependencies between tests.
Review Request #4598 — Created Sept. 20, 2013 and submitted
Speed up the tests further, and remove interdependencies between tests.
Several of the tests would call other tests to set up data, invoking API
requests to provide the data, which added to the test execution time.
This also made it harder to separate tests out into list/item suites.The tests are now setting up their data using the new factory methods
instead of calling other test functions.
Unit tests pass. This shaves roughly 4 more seconds off tests.
| Description | From | Last Updated |
|---|---|---|
|
'FileAttachment' imported but unused |
 reviewbot
|
|
|
local variable 'reply' is assigned to but never used |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'LocalSite' imported but unused |
reviewbot
|
|
|
'review_reply_diff_comment_list_mimetype' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'LocalSite' imported but unused |
reviewbot
|
|
|
'review_reply_file_attachment_comment_list_mimetype' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'LocalSite' imported but unused |
reviewbot
|
|
|
'review_reply_screenshot_comment_list_mimetype' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
'User' imported but unused |
reviewbot
|
|
|
Looks like you duplicated this instead of replacing it. |
 david
|
|
|
is probably more appropriate than () now that there's only one item. |
david
|
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files: -
reviewboard/webapi/tests/test_file_attachment.py (Diff revision 1) 'FileAttachment' imported but unused
-
reviewboard/webapi/tests/test_review_reply.py (Diff revision 1) local variable 'reply' is assigned to but never used
-
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1) 'User' imported but unused
-
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1) 'LocalSite' imported but unused
-
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1) 'review_reply_diff_comment_list_mimetype' imported but unused
-
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1) 'User' imported but unused
-
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1) 'LocalSite' imported but unused
-
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1) 'review_reply_file_attachment_comment_list_mimetype' imported but unused
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1) 'User' imported but unused
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1) 'LocalSite' imported but unused
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1) 'review_reply_screenshot_comment_list_mimetype' imported but unused
-
-
reviewboard/webapi/tests/test_watched_review_request.py (Diff revision 1) 'User' imported but unused
Change Summary:
Addressed ReviewBot's concerns.
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:
-
-
reviewboard/webapi/tests/test_file_diff_comment.py (Diff revision 2) Looks like you duplicated this instead of replacing it.
-
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 2) is probably more appropriate than () now that there's only one item.
Change Summary:
- Fix some pyflakes warnings.
- Removed a duplicate fixtures line, and some duplicate functions from a merge.
Diff: |
Revision 3 (+467 -347)
|
|---|
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files: