Review Request #4598: Speed up the tests further, and remove interdependencies between tests.

Description	From	Last Updated
'FileAttachment' imported but unused	reviewbot	Sept. 21, 2013, 8:09 a.m.
local variable 'reply' is assigned to but never used	reviewbot	Sept. 21, 2013, 8:09 a.m.
'User' imported but unused	reviewbot	Sept. 21, 2013, 8:10 a.m.
'LocalSite' imported but unused	reviewbot	Sept. 21, 2013, 8:10 a.m.
'review_reply_diff_comment_list_mimetype' imported but unused	reviewbot	Sept. 21, 2013, 8:11 a.m.
'User' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'LocalSite' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'review_reply_file_attachment_comment_list_mimetype' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'User' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'LocalSite' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'review_reply_screenshot_comment_list_mimetype' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'User' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
'User' imported but unused	reviewbot	Sept. 21, 2013, 8:13 a.m.
Looks like you duplicated this instead of replacing it.	david	Sept. 21, 2013, 10:26 a.m.
is probably more appropriate than () now that there's only one item.	david	Sept. 21, 2013, 10:28 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

reviewboard/webapi/tests/test_file_attachment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'FileAttachment' imported but unused
```
reviewboard/webapi/tests/test_review_reply.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'reply' is assigned to but never used
```
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'User' imported but unused
```
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_review_reply_diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'review_reply_diff_comment_list_mimetype' imported but unused
```
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'User' imported but unused
```
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'review_reply_file_attachment_comment_list_mimetype' imported but unused
```
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'User' imported but unused
```
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'review_reply_screenshot_comment_list_mimetype' imported but unused
```
reviewboard/webapi/tests/test_watched_review_group.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'User' imported but unused
```
reviewboard/webapi/tests/test_watched_review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'User' imported but unused
```

Change Summary:

Addressed ReviewBot's concerns.

Diff:

Revision 2 (+467 -346)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/tests/test_file_attachment.py
	reviewboard/webapi/tests/test_file_attachment_comment.py
	reviewboard/webapi/tests/test_file_attachment_draft.py
	reviewboard/webapi/tests/test_file_diff_comment.py
	reviewboard/webapi/tests/test_review.py
	reviewboard/webapi/tests/test_review_comment.py
	reviewboard/webapi/tests/test_review_reply.py
	7 more

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

reviewboard/webapi/tests/test_file_diff_comment.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Looks like you duplicated this instead of replacing it.
```
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 is probably more appropriate than () now that there's only one item.
```

Change Summary:


Fix some pyflakes warnings.
Removed a duplicate fixtures line, and some duplicate functions from a merge.

Diff:

Revision 3 (+467 -347)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/tests/test_file_attachment.py
	reviewboard/webapi/tests/test_file_attachment_comment.py
	reviewboard/webapi/tests/test_file_attachment_draft.py
	reviewboard/webapi/tests/test_file_diff_comment.py
	reviewboard/webapi/tests/test_review.py
	reviewboard/webapi/tests/test_review_comment.py
	reviewboard/webapi/tests/test_review_reply.py
	7 more

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/testing/testcase.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed

Review Board 7.0.2 alpha 0 (dev)

Speed up the tests further, and remove interdependencies between tests.

Information

Reviewers