Fix up our manage.py for Django 1.3 deprecations.

Review Request #4589 — Created Sept. 17, 2013 and submitted

Information

Review Board
master

Reviewers

Fix up our manage.py for Django 1.3 deprecations.

The setup_environ() and execute_manager() methods were deprecated, in favor of
the new execute_from_command_line() and setting the DJANGO_SETTINGS_MODULE
variable. These were deprecated in Django 1.3 and removed in 1.5. We inherited
these by virtue of the fact that we modified the old manage.py--this updates
our code to look more like the new manage.py.

  • Ran unit tests
  • Used the devserver a bit
Description From Last Updated

'recaptcha' imported but unused

reviewbotreviewbot

We do this twice now. Do we need the first one? Single quotes?

chipx86chipx86

'recaptcha' imported but unused

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/manage.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/manage.py
    Ignored Files:

  2. reviewboard/manage.py (Diff revision 1)
     
     

    'recaptcha' imported but unused

  3. 
      
chipx86
  1. 
      
  2. reviewboard/manage.py (Diff revision 1)
     
     

    We do this twice now. Do we need the first one?

    Single quotes?

  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/manage.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/manage.py
    Ignored Files:

  2. reviewboard/manage.py (Diff revision 2)
     
     

    'recaptcha' imported but unused

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (30367fd).

Loading...