Don't blindly call next_page_number() or previous_page_number().
Review Request #4587 — Created Sept. 17, 2013 and submitted
Don't blindly call next_page_number() or previous_page_number().
The pagination methods have been changed to raise EmptyPageError if there's no
such page. We therefore can't blindly add things to the context, but rather
should check that the pages exist before we call these methods.
- Loaded the Review Board dashboard.
- Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Can you put blank lines around these? Too crowded for my tastes. I tend to end up reading these as … |
 chipx86
|
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
djblets/datagrid/grids.py
Ignored Files:
-
-
djblets/datagrid/grids.py (Diff revision 1) Can you put blank lines around these? Too crowded for my tastes. I tend to end up reading these as "elifs' and stuff.
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
djblets/datagrid/grids.py
Ignored Files: