Clean up the order of webapi tests.

Review Request #4586 — Created Sept. 17, 2013 and submitted

chipx86
Review Board
master
reviewboard

Clean up the order of webapi tests.

This is the next part of my master plan to improve the webapi test
suite. Tests are now divided into List and Item tests, and within these,
the tests are ordered alphabetically by HTTP method.

The next part will be to group list and item tests under their own test
suites and to simplify the function names.

There were no logic changes made to tests. They've only moved around.
However, some functions were renamed to use "put" or "post" instead of
"update" or "create".

Unit tests passed.

Description From Last Updated

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

'get_review_list_url' imported but unused

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/test_screenshot_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    Ignored Files:

  2. Col: 80
    E501 line too long (81 > 79 characters)

  3. reviewboard/webapi/tests/test_review.py (Diff revision 1)
     
     

    Col: 80
    E501 line too long (96 > 79 characters)

  4. Col: 80
    E501 line too long (80 > 79 characters)

  5. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_file_attachment_comment.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/test_screenshot_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    Ignored Files:

  2. 'get_review_list_url' imported but unused

  3. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...