Summary

Clean up the order of webapi tests.

Review Request #4586 — Created Sept. 17, 2013 and submitted Sept. 28, 2013, 2:20 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Clean up the order of webapi tests.
This is the next part of my master plan to improve the webapi test

suite. Tests are now divided into List and Item tests, and within these,

the tests are ordered alphabetically by HTTP method.
The next part will be to group list and item tests under their own test

suites and to simplify the function names.
There were no logic changes made to tests. They've only moved around.

However, some functions were renamed to use "put" or "post" instead of

"update" or "create".

Testing Done

Unit tests passed.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Sept. 17, 2013, 3:59 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Sept. 17, 2013, 3:59 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 17, 2013, 4 p.m.
'get_review_list_url' imported but unused	reviewbot	Sept. 17, 2013, 4:01 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_default_reviewer.py
reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
reviewboard/webapi/tests/test_repository_commits.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_group.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_change.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_user.py
reviewboard/webapi/tests/test_screenshot_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
reviewboard/webapi/tests/test_diff.py
reviewboard/webapi/tests/test_repository.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_review_group_user.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

reviewboard/webapi/tests/test_default_reviewer.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/tests/test_review.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (96 > 79 characters)
```
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
reviewboard/webapi/tests/test_review_screenshot_comment.py
reviewboard/webapi/tests/test_file_diff_comment.py
reviewboard/webapi/tests/test_watched_review_request.py
reviewboard/webapi/tests/test_review.py
reviewboard/webapi/tests/test_default_reviewer.py
reviewboard/webapi/tests/test_draft_review_screenshot_comment.py
reviewboard/webapi/tests/test_repository_commits.py
reviewboard/webapi/tests/test_review_comment.py
reviewboard/webapi/tests/test_review_group.py
reviewboard/webapi/tests/test_file_attachment_draft.py
reviewboard/webapi/tests/test_change.py
reviewboard/webapi/tests/test_review_reply.py
reviewboard/webapi/tests/test_file_attachment_comment.py
reviewboard/webapi/tests/test_user.py
reviewboard/webapi/tests/test_screenshot_comment.py
reviewboard/webapi/tests/test_watched_review_group.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
reviewboard/webapi/tests/test_draft_review_file_attachment_comment.py
reviewboard/webapi/tests/test_diff.py
reviewboard/webapi/tests/test_repository.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
reviewboard/webapi/tests/test_review_group_user.py
reviewboard/webapi/tests/test_review_reply_diff_comment.py
reviewboard/webapi/tests/test_screenshot_draft.py
Ignored Files:

reviewboard/webapi/tests/test_review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'get_review_list_url' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed