Adjust the way that we override HttpResponse.content.

Review Request #4583 — Created Sept. 17, 2013 and submitted

Information

Djblets
master

Reviewers

Adjust the way that we override HttpResponse.content.

The WebAPIResponse.content property overrides Django's HttpResponse.content in
kind of a hacky way, using private APIs that have gone away in Django 1.5. This
change overrides the property by proxying back in to the content property in
the super class. This is kind of awkward because of the way that properties
work, but the method herein seems to work and is much less gross than the
previous approach.

Ran unit tests

Description From Last Updated

'BasicAPIEncoder' imported but unused

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    djblets/webapi/core.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    djblets/webapi/core.py
    Ignored Files:

  2. djblets/webapi/core.py (Diff revision 1)
     
     
    Show all issues

    'BasicAPIEncoder' imported but unused

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (f90d629).

Loading...