Switch function-based generic views to class-based ones.

Review Request #4582 — Created Sept. 17, 2013 and submitted

Information

Review Board
master

Reviewers

Switch function-based generic views to class-based ones.

The old object_list and redirect_to views are gone, in favor of ListView and
RedirectView. This change switches us over to them.

  • Verified that views still worked.
  • Ran unit tests.
Description From Last Updated

undefined name 'self'

reviewbotreviewbot

undefined name 'local_site_name'

reviewbotreviewbot

Are these not needed anymore?

chipx86chipx86

undefined name 'ReviewSearchView'

reviewbotreviewbot

undefined name 'ReviewSearchView'

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. reviewboard/reviews/views.py (Diff revision 1)
     
     

    undefined name 'self'

  3. reviewboard/reviews/views.py (Diff revision 1)
     
     

    undefined name 'local_site_name'

  4. 
      
david
  1. Hold off on this. I didn't actually test the search view (because lucene), and it shows.

  2. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
chipx86
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 2)
     
     
     

    Are these not needed anymore?

  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. reviewboard/reviews/views.py (Diff revision 3)
     
     

    undefined name 'ReviewSearchView'

  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. reviewboard/reviews/views.py (Diff revision 4)
     
     

    undefined name 'ReviewSearchView'

  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/urls.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py
    Ignored Files:

  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (4befefc).

Loading...