Summary

Switch function-based generic views to class-based ones.

Review Request #4582 — Created Sept. 17, 2013 and submitted Sept. 17, 2013, 4:43 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Switch function-based generic views to class-based ones.

The old object_list and redirect_to views are gone, in favor of ListView and
RedirectView. This change switches us over to them.

Testing Done


Verified that views still worked.
Ran unit tests.

Issues

Description	From	Last Updated
undefined name 'self'	reviewbot	Sept. 17, 2013, 2:02 p.m.
undefined name 'local_site_name'	reviewbot	Sept. 17, 2013, 2:02 p.m.
Are these not needed anymore?	chipx86	Sept. 17, 2013, 4:18 p.m.
undefined name 'ReviewSearchView'	reviewbot	Sept. 17, 2013, 4:28 p.m.
undefined name 'ReviewSearchView'	reviewbot	Sept. 17, 2013, 4:29 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'self'
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'local_site_name'
```

Hold off on this. I didn't actually test the search view (because lucene), and it shows.

david Sept. 17, 2013, 3:22 p.m.
```
Ready to go now.
```

Diff:

Revision 2 (+67 -80)

Show changes

	reviewboard/urls.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Are these not needed anymore?
```

Diff:

Revision 3 (+77 -80)

Show changes

	reviewboard/urls.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
undefined name 'ReviewSearchView'
```

Change Summary:

Syntax.

Diff:

Revision 4 (+77 -80)

Show changes

	reviewboard/urls.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

reviewboard/reviews/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
undefined name 'ReviewSearchView'
```

Change Summary:

Gah, forgot to git commit. Sorry for the spam :(

Diff:

Revision 5 (+77 -80)

Show changes

	reviewboard/urls.py
	reviewboard/admin/urls.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/urls.py
Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (4befefc).