Bug Fix for Issue #1075
Review Request #4578 — Created Sept. 17, 2013 and submitted
Issue:Include submitted review requests in the "Starred Reviews" page in the dashboard.
While users can star submitted reviews, they do not appear in the "Starred Reviews" page of the dashboard. To fix this, I modified DashboardDataGrid to include submitted reviews when it displays the starred reviews, by filtering all public starred reviews. Also, we need to keep the counts for starred reviews consistent, so in accounts.Profile, I included ReviewRequest.SUBMITTED when we star or unstar a review request.
Manual testing: starred and unstarred a combination of submitted and non-submitted reviews to see if they would be displayed properly on the dashboard.
| Description | From | Last Updated |
|---|---|---|
|
Alignment is a little funky here. Please indent it like this: if (review_request.public and (review_request.status == ReviewRequest.PENDING_REVIEW or review_request.status == … |
 david
|
|
|
Same here w/ alignment. |
david
|
|
|
Please revert these changes. |
david
|
|
|
This changes the query in bad ways: * It skips the check that adds users' un-published review requests * You've … |
david
|
|
|
Col: 38 W291 trailing whitespace |
 reviewbot
|
|
|
Col: 62 E202 whitespace before ')' |
reviewbot
|
|
|
Col: 63 W291 trailing whitespace |
reviewbot
|
-
-
reviewboard/accounts/models.py (Diff revision 1) Alignment is a little funky here. Please indent it like this:
if (review_request.public and (review_request.status == ReviewRequest.PENDING_REVIEW or review_request.status == ReviewRequest.SUBMITTED)): site_profile... -
-
-
reviewboard/reviews/datagrids.py (Diff revision 1) This changes the query in bad ways: * It skips the check that adds users' un-published review requests * You've removed the local_site restriction
I think what we want here is something more like this:
self.queryset = profile.starred_review_requests.public( user, local_site=self.local_site, status=None)
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/accounts/models.py
reviewboard/reviews/datagrids.py
Ignored Files: -
-
-
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/accounts/models.py
reviewboard/reviews/datagrids.py
Ignored Files:
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/accounts/models.py
reviewboard/reviews/datagrids.py
Ignored Files:
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/accounts/models.py
reviewboard/reviews/datagrids.py
Ignored Files: