Clean up the view_diff.html template.

Review Request #4568 — Created Sept. 14, 2013 and submitted

Information

Review Board
master

Reviewers

Clean up the view_diff.html template.

This change removes some obsolete variable definitions, fixes indentation on
template tags, and generally cleans things up.

Played around with the diff viewer a bit and checked that things looked right.

Description From Last Updated

While here, can you combine these into one line? We should go through and do that with more templates, since …

chipx86chipx86

Looks like these are still indented wrong.

chipx86chipx86

Probably should still wrap to < 80 though. Two lines is fine, just so long as we're not doing one …

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    reviewboard/templates/diffviewer/view_diff.html

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    reviewboard/templates/diffviewer/view_diff.html

  2. 
      
chipx86
  1. 
      
  2. reviewboard/templates/diffviewer/view_diff.html (Diff revision 1)
     
     
     
     
     
     
     
     
     

    While here, can you combine these into one line? We should go through and do that with more templates, since it's faster to load the modules in one or two load tags than to have a bunch of load tags. (Django's templates are sadly slow...)

  3. Looks like these are still indented wrong.

  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    reviewboard/templates/diffviewer/view_diff.html

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    reviewboard/templates/diffviewer/view_diff.html

  2. 
      
chipx86
  1. After this, ship it.

  2. Probably should still wrap to < 80 though. Two lines is fine, just so long as we're not doing one per.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (27b0233).

Loading...