Summary

Clean up the view_diff.html template.

Review Request #4568 — Created Sept. 14, 2013 and submitted Sept. 16, 2013, 10:03 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Clean up the view_diff.html template.

This change removes some obsolete variable definitions, fixes indentation on
template tags, and generally cleans things up.

Testing Done

Played around with the diff viewer a bit and checked that things looked right.

Issues

Description	From	Last Updated
While here, can you combine these into one line? We should go through and do that with more templates, since …	chipx86	Sept. 15, 2013, 9:16 a.m.
Looks like these are still indented wrong.	chipx86	Sept. 15, 2013, 9:19 a.m.
Probably should still wrap to < 80 though. Two lines is fine, just so long as we're not doing one …	chipx86	Sept. 16, 2013, 10:01 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html

reviewboard/templates/diffviewer/view_diff.html (Diff revision 1)

The issue has been resolved. Show all issues

While here, can you combine these into one line? We should go through and do that with more templates, since it's faster to load the modules in one or two load tags than to have a bunch of load tags. (Django's templates are sadly slow...)

reviewboard/templates/diffviewer/view_diff.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Looks like these are still indented wrong.
```

Diff:

Revision 2 (+52 -63)

Show changes

reviewboard/templates/diffviewer/view_diff.html

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html

```
After this, ship it.
```

reviewboard/templates/diffviewer/view_diff.html (Diff revision 2)

The issue has been resolved. Show all issues

Probably should still wrap to < 80 though. Two lines is fine, just so long as we're not doing one per.

Status:: Completed
Change Summary:: Pushed to master (27b0233).