Move the diff revision selector into javascript.
Review Request #4565 — Created Sept. 13, 2013 and submitted
Move the diff revision selector into javascript.
Rather than generating this from the django template and including links, it's
now generated on the client-side, and clicks are handled by triggering the
"revisionSelected" event. This still ends up navigating to another page, but
it's a step towards avoiding the reload.
- Navigated to different diff and interdiff revisions.
- Ran js-tests.
- Ran jshint.
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
reviewboard/diffviewer/templatetags/difftags.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/static/rb/js/pages/views/diffViewerPageView.js -
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
-
-
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js (Diff revision 1) Could be one line.
-
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js (Diff revision 1) Could be one line.
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
reviewboard/diffviewer/templatetags/difftags.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
reviewboard/diffviewer/templatetags/difftags.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/static/rb/js/pages/views/diffViewerPageView.js -
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names