Summary

Move the diff revision selector into javascript.

Review Request #4565 — Created Sept. 13, 2013 and submitted Sept. 16, 2013, 11 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Move the diff revision selector into javascript.

Rather than generating this from the django template and including links, it's
now generated on the client-side, and clicks are handled by triggering the
"revisionSelected" event. This still ends up navigating to another page, but
it's a step towards avoiding the reload.

Testing Done


Navigated to different diff and interdiff revisions.
Ran js-tests.
Ran jshint.

Issues

Description	From	Last Updated
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 13, 2013, 10:31 p.m.
Could be one line.	chipx86	Sept. 14, 2013, 5:31 a.m.
Could be one line.	chipx86	Sept. 14, 2013, 5:31 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 14, 2013, 5:53 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
reviewboard/diffviewer/templatetags/difftags.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
reviewboard/diffviewer/templatetags/difftags.py
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Could be one line.
```
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Could be one line.
```

Diff:

Revision 2 (+130 -92)

Show changes

	reviewboard/settings.py
	reviewboard/diffviewer/templatetags/difftags.py
	reviewboard/static/rb/css/diffviewer.less
	reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.js
	reviewboard/templates/diffviewer/view_diff.html

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (813d2a7).