Add ExtensionMiddlewareRunner middleware

Review Request #4563 — Created Sept. 12, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Add ExtensionMiddlewareRunner middleware from djblets.

All tests pass:

Ran 746 tests in 68.571s

OK (SKIP=12)

The skipped tests are all related to perforce, which I don't have installed. They should be unrelated to my patch.

Description From Last Updated

Does this need to be last? If so, please add a comment beforehand, or it'll end up getting rearranged at …

chipx86chipx86

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/settings.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/settings.py
    Ignored Files:

  2. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues

    'from settings_local import *' used; unable to detect undefined names

  3. 
      
chipx86
  1. 
      
  2. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues

    Does this need to be last? If so, please add a comment beforehand, or it'll end up getting rearranged at some point. See what we have or the INSTALLED_APPS.

    Also, make sure the docstring for ExtensionsMiddlewareRunner also states that it must be last.

    1. Good point. I don't know if it absolutely needs to go last, since we don't know what an extension's middleware will do, but it's probably a good idea anyways, so that it comes after everything in ReviewBoard and djblets has been initialized. I'll put that in a comment.

  3. 
      
MC
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/settings.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/settings.py
    Ignored Files:

  2. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues

    'from settings_local import *' used; unable to detect undefined names

  3. 
      
SM
  1. Ship It!

  2. 
      
mike_conley
  1. Looks good to me.

  2. 
      
david
  1. Ship It!

  2. 
      
MC
Review request changed
Status:
Completed
Change Summary:

Pushed to release-1.7.x (404a52e). Thanks!