Add ExtensionMiddlewareRunner middleware
Review Request #4563 — Created Sept. 12, 2013 and submitted
| Information | |
|---|---|
| mcote | |
| Review Board | |
| release-1.7.x | |
|
|
|
| Reviewers | |
| reviewboard | |
| smacleod | |
Add ExtensionMiddlewareRunner middleware from djblets.
All tests pass:
Ran 746 tests in 68.571s
OK (SKIP=12)
The skipped tests are all related to perforce, which I don't have installed. They should be unrelated to my patch.
| Description | From | Last Updated |
|---|---|---|
|
Does this need to be last? If so, please add a comment beforehand, or it'll end up getting rearranged at … |
 chipx86
|
|
|
'from settings_local import *' used; unable to detect undefined names |
 reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
Ignored Files: -
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
-
-
reviewboard/settings.py (Diff revision 1) Does this need to be last? If so, please add a comment beforehand, or it'll end up getting rearranged at some point. See what we have or the INSTALLED_APPS.
Also, make sure the docstring for ExtensionsMiddlewareRunner also states that it must be last.
MC
Change Summary:
Added comment about positioning within middleware list.
Branch: |
|
||||
|---|---|---|---|---|---|
Depends On: |
|
||||
Diff: |
Revision 2 (+4) |
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
Ignored Files:
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
Ignored Files: -
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
