Summary

Add ExtensionMiddlewareRunner middleware

Review Request #4563 — Created Sept. 12, 2013 and submitted Oct. 8, 2013, 2:14 p.m.

Information

Owner

mcote

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

~~4530~~

Reviewers

Groups

reviewboard

People

smacleod

Description

Add ExtensionMiddlewareRunner middleware from djblets.

Testing Done

All tests pass:

Ran 746 tests in 68.571s

OK (SKIP=12)

The skipped tests are all related to perforce, which I don't have installed. They should be unrelated to my patch.

Issues

Description	From	Last Updated
Does this need to be last? If so, please add a comment beforehand, or it'll end up getting rearranged at …	chipx86	Sept. 16, 2013, 2:23 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 12, 2013, 6:10 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 17, 2013, 1:19 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
Ignored Files:

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

reviewboard/settings.py (Diff revision 1)

The issue has been resolved. Show all issues

Does this need to be last? If so, please add a comment beforehand, or it'll end up getting rearranged at some point. See what we have or the INSTALLED_APPS.

Also, make sure the docstring for ExtensionsMiddlewareRunner also states that it must be last.

mcote Sept. 16, 2013, 2:23 p.m.

Good point. I don't know if it absolutely needs to go last, since we don't know what an extension's middleware will do, but it's probably a good idea anyways, so that it comes after everything in ReviewBoard and djblets has been initialized. I'll put that in a comment.

Change Summary:

Added comment about positioning within middleware list.

Branch:

-	master
+	release-1.7.x

Depends On:

+	~~4530 - Add support for middleware to extensions~~

Diff:

Revision 2 (+4)

Show changes

reviewboard/settings.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
Ignored Files:

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Ship it!

```
Looks good to me.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (404a52e). Thanks!