Summary

Remove the trailing blank line in markdown text.

Review Request #4533 — Created Sept. 6, 2013 and submitted Sept. 11, 2013, 1:15 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Remove the trailing blank line in markdown text.
The markup() function returns a string with an extra blank line (as

every HTML tag is outputted with a trailing newline). We don't really

want this, since it leaves a blank line in each <pre>, so check if

there's a newline and strip it away. This brings the look to how we had

things pre-markdown.

Testing Done

Tested locally with different text. The textboxes no longer had the
annoying final newline.

Unit tests pass.

Issues

Description	From	Last Updated
Could we use .trim() instead?	david	Sept. 11, 2013, 2:53 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/utils/textUtils.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/utils/textUtils.js

reviewboard/static/rb/js/utils/textUtils.js (Diff revision 1)

The issue has been resolved. Show all issues

Could we use .trim() instead?

chipx86 Sept. 6, 2013, 2:20 p.m.

We could, but I'm not sure if we want to, at least not here. I was trying to be cautious and only get rid of the newline that markup() places, and not any that were inserted as part of the text, since they'll otherwise still be there in the original content and affect the size when editing anyway.