Summary

Add filtering for the repository selector.

Review Request #4526 — Created Sept. 4, 2013 and submitted Sept. 5, 2013, 4:18 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add filtering for the repository selector.

This change adds a search box for the repository list, which should help for
servers that have a ton of repos connected.

Testing Done


Tested the animation back and forth to make sure everything was silky smooth

  and drew correctly.
Added a couple repositories with different names. Checked that searches

  worked as expected.
Ran jshint.

Files

Issues

Description	From	Last Updated
It's a bit cramped and harsh. I'd suggest 2px padding inside, and a border color closer to #CCC or #999. …	chipx86	Sept. 5, 2013, 4:05 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
reviewboard/static/rb/css/newReviewRequest.less
reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
reviewboard/static/rb/css/newReviewRequest.less
reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

3.png

The issue has been resolved. Show all issues

It's a bit cramped and harsh. I'd suggest 2px padding inside, and a border color closer to #CCC or #999.

Maybe give it a lighter background too? It can still be dark, but lighter than the current color.

Diff:

Revision 2 (+107 -1)

Show changes

	reviewboard/static/rb/css/newReviewRequest.less
	reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
	reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

Added Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (0825890).