Add filtering for the repository selector.

Review Request #4526 — Created Sept. 4, 2013 and submitted

Information

Review Board
master

Reviewers

Add filtering for the repository selector.

This change adds a search box for the repository list, which should help for
servers that have a ton of repos connected.

  • Tested the animation back and forth to make sure everything was silky smooth
    and drew correctly.
  • Added a couple repositories with different names. Checked that searches
    worked as expected.
  • Ran jshint.

Description From Last Updated

It's a bit cramped and harsh. I'd suggest 2px padding inside, and a border color closer to #CCC or #999. …

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
    reviewboard/static/rb/css/newReviewRequest.less
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
    reviewboard/static/rb/css/newReviewRequest.less
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

  2. 
      
chipx86
  1. 
      
  2. It's a bit cramped and harsh. I'd suggest 2px padding inside, and a border color closer to #CCC or #999.

    Maybe give it a lighter background too? It can still be dark, but lighter than the current color.

  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
    reviewboard/static/rb/css/newReviewRequest.less
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
    reviewboard/static/rb/css/newReviewRequest.less
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js

  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (0825890).

Loading...