Summary

rbt patch subcommand to support --print option

Review Request #4525 — Created Sept. 3, 2013 and submitted Sept. 4, 2013, 2:30 p.m.

Information

Owner

sudhirbs

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

chipx86, david

Description

rbt patch subcommand to support --print option. Option to stdout allows more flexibility. i.e. in case the patching fails, or the user wants to inspect without patching. This change adds --print as an option to 'patch' subcommand.

Testing Done

Yes with private installation.

Issues

Description	From	Last Updated
How would you feel about --print instead of --stdout?	david	Sept. 4, 2013, 2:14 p.m.
Can you change this to be "print patch to stdout instead of applying" ?	david	Sept. 4, 2013, 2:14 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
rbtools/commands/patch.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
rbtools/commands/patch.py
Ignored Files:

rbtools/commands/patch.py (Diff revision 1)

Show all issues

How would you feel about --print instead of --stdout?

rbtools/commands/patch.py (Diff revision 1)

Show all issues

Can you change this to be "print patch to stdout instead of applying" ?

Change Summary:

Hi David,

I have got the changes you suggested in this revision.

Regards
Sudhir

Diff:

Revision 2 (+10 -3)

Show changes

rbtools/commands/patch.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
rbtools/commands/patch.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
rbtools/commands/patch.py
Ignored Files:

Change Summary:

Changed Summary and Description fields to say --print instead --stdout.

Summary:

-	rbt patch subcommand to support --stdout option
+	rbt patch subcommand to support --print option

Description:

~		rbt patch subcommand to support --stdout option. Option to stdout allows more flexibility. i.e. in case the patching fails, or the user wants to inspect without patching. This change adds --stdout as an option to patch subcommand.
	~	rbt patch subcommand to support --print option. Option to stdout allows more flexibility. i.e. in case the patching fails, or the user wants to inspect without patching. This change adds --print as an option to 'patch' subcommand.

Status: Closed (submitted)

Change Summary:

Pushed to rbtools master (f5ec3b6). Thanks!

Ship it!

```
Ship It!
```