-
-
trunk/reviewboard/scmtools/hg.py (Diff revision 1) Are we guaranteed that diffLine[3] will be "-r" when it's uncommitted?
-
trunk/reviewboard/scmtools/hg.py (Diff revision 1) We usually prefer these to be more verbose. What you could so is: isCommitted = ... if isCommitted: nameStartIndex = 5 info[...] else: nameStartIndex = 3 info[...]
-
trunk/reviewboard/scmtools/hg.py (Diff revision 1) You should probably use urllib.quote() for escaping contents.
Patch: Enable support for paths with spaces in Mercurial (hg) diff parser
Review Request #451 — Created July 16, 2008 and submitted
Information | |
---|---|
derek | |
Review Board SVN (deprecated) | |
541 | |
Reviewers | |
reviewboard | |
Enables the Mercurial diff parser to handle file paths with spaces. I don't know Python, and was therefore "coding by Google", so please expect to find some issues. Update: diff #2 comes with proposed changes generously applied by bboissin (via http://code.google.com/p/reviewboard/issues/detail?id=541)
Tested locally on Debian with various changesets that do and do not include paths with spaces.