Exclude diff-associated FileAttachments from the resource list.

Review Request #4508 — Created Aug. 29, 2013 and submitted

Information

Review Board
master

Reviewers

Exclude diff-associated FileAttachments from the resource list.

FileAttachments associated with a FileDiff shouldn't be shown in the
list of a review request's file attachments. Exclude them from the list.
A future change will add proper API for setting and getting attachments
on a FileDiff.

Also, while here, I added the missing mimetype field.
Unit tests pass.
Description From Last Updated

local variable 'file_attachments_url' is assigned to but never used

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/tests.py
        reviewboard/webapi/resources.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/webapi/tests.py
        reviewboard/webapi/resources.py
      Ignored Files:
    
    
  2. reviewboard/webapi/tests.py (Diff revision 1)
     
     
     local variable 'file_attachments_url' is assigned to but never used
    
  3. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...