This change has been marked as completed.

Describe the completed change (optional):

Summary

Exclude diff-associated FileAttachments from the resource list.

Review Request #4508 — Created Aug. 29, 2013 and submitted 11 years, 9 months ago

Information

Owner

chipx86*

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

Exclude diff-associated FileAttachments from the resource list.

FileAttachments associated with a FileDiff shouldn't be shown in the
list of a review request's file attachments. Exclude them from the list.
A future change will add proper API for setting and getting attachments
on a FileDiff.

Also, while here, I added the missing mimetype field.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
local variable 'file_attachments_url' is assigned to but never used	reviewbot	11 years, 9 months ago
There are no open issues

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

reviewboard/webapi/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'file_attachments_url' is assigned to but never used
```

Ship it!

```
Ship It!
```

Status:: Completed

reviewboard/webapi/tests.py (Diff revision 1)