Make field formatters in ReviewRequestEditorView set the element's html.

Review Request #4490 — Created Aug. 26, 2013 and submitted

Information

Review Board
master

Reviewers

Make field formatters in ReviewRequestEditorView set the element's html.

ReviewRequestEditorView's field definitions have an abstract "formatter"
concept, which was a function that would mutate the value before setting it in
the DOM. This change moves the responsibility for calling jQuery.html() into
the formatter functions themselves. The motivation for this is that the coming
markdown changes will need to do some fancier stuff including accessing data
attributes on the element (to check if it should be formatted as rich text),
and setting the rich-text class once it's been formatted.
Ran js-tests.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (969af5b).
Loading...