Summary

Split RB.linkifyText into separate pieces.

Review Request #4489 — Created Aug. 26, 2013 and submitted Aug. 27, 2013, 3:56 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Split RB.linkifyText into separate pieces.

The linkifyText method does a bunch of things. It starts out by escaping out <
and > characters (which doesn't have much to do with linkifying), and then
proceeds to create links for any full URLs, /r/### review requests, and bug
numbers.

When we integrate markdown support for text boxes, we don't want the <>
escaping, and full URLs will be handled by the markdown parser. We therefore
want to be able to call subsets of this functionality in addition to the whole.

Testing Done

Ran js-tests

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/js/utils/linkifyUtils.js
    reviewboard/static/rb/js/views/reviewBoxView.js
    reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/js/utils/linkifyUtils.js
    reviewboard/static/rb/js/views/reviewBoxView.js
    reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (3e850ef).