LDAP: Use fully qualified DN for authentication

Review Request #4488 — Created Aug. 26, 2013 and submitted

Information

Review Board
master

Reviewers

Use the fully qualified DN with LDAP bind for user authentication.
Currently a DN built with the base DN and uid is used. This did not work on our company LDAP server.
Code running successful with our company LDAP server.
Description From Last Updated

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 32 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 28 E225 missing whitespace around operator

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/accounts/backends.py
      Ignored Files:
    
    
  2. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (83 > 79 characters)
    
  3. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  4. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  5. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Col: 32
     W291 trailing whitespace
    
  6. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (87 > 79 characters)
    
  7. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Col: 28
     E225 missing whitespace around operator
    
  8. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/accounts/backends.py
      Ignored Files:
    
    
  2. 
      
HG
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/accounts/backends.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/accounts/backends.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
HG
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (39c6ab6). Thanks!

Loading...