Summary

Rename scmtools.crypto to scmtools.crypto_utils

Review Request #4483 — Created Aug. 25, 2013 and submitted Aug. 27, 2013, 5:29 p.m.

Information

Owner

smacleod

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Rename scmtools.crypto to scmtools.crypto_utils

On case-insensitive file systems, the import of 'Crypto' inside
scmtools.crypto will fail. This problem also appears when attempting to
run Review Board inside a Linux Virtual Machine, where the code has been
shared from a Mac OSX Host. Since the default OSX filesystem is
case-insensitive, case-preserving, the import will fail as well.

Testing Done

The import now succeeds after the patch, and the unit tests exercising this code now pass.

Issues

Description	From	Last Updated
We're using parens now for multi-line imports. ... import (decrypt_password, encrypt_password)	chipx86	Aug. 27, 2013, 4:53 p.m.
Here too.	chipx86	Aug. 27, 2013, 4:54 p.m.

reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)

Show all issues

We're using parens now for multi-line imports.

... import (decrypt_password,
            encrypt_password)

reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)
Show all issues
```
Here too.
```

Change Summary:

Updated to new style

Diff:

Revision 2 (+4 -2)

Show changes

	reviewboard/hostingsvcs/beanstalk.py
	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/scmtools/crypto.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (52279087307cffe99f81dd9cd829b48fcac4b9e4)