Summary

Build and ship compiled locale files.

Review Request #4482 — Created Aug. 23, 2013 and submitted Aug. 26, 2013, 2:07 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Build and ship compiled locale files.

This adds another compilation step to the egg build: locale files. We keep the
.po files checked in to git, but we don't want to check in .mo files because
they're big binary blobs that may change frequently, and git doesn't do so well
with that.

This requires that msgfmt from the xgettext package is installed somewhere in
the path. On OSX, I've installed it via homebrew, but that doesn't add it to
the user path by default because of some conflicts.

Testing Done

- Built a .egg and installed it. Verified that both .po and .mo files were
  included in the correct location.
- Changed my PATH so that msgfmt could not be found. Saw the bdist_egg command
  error out.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
  Ignored Files:

Change Summary:

Had some uncommitted changes

Diff:

Revision 2 (+30 -1)

Show changes

setup.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
  Ignored Files:

Looks fine. Hopefully it doesn't make things more difficult for students to get going, though.

I'd like some good instructions written up someplace on getting the proper things installed on OS X before this is submitted, so I'm not blocked. Can you include that in Getting Started as part of this change?

david Aug. 23, 2013, 4:22 p.m.

This shouldn't make anything more difficult unless you're cutting releases, in which case you need gettext.

I'll add a note to Getting Started, but I don't want it to be too onerous, since it's a pretty specialized use case. Do you use homebrew/fink/etc?

Change Summary:

Add gettext to the getting started doc

Diff:

Revision 3 (+34 -1)

Show changes

	setup.py
	docs/codebase/getting-started.txt

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
  Ignored Files:
    docs/codebase/getting-started.txt

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
  Ignored Files:
    docs/codebase/getting-started.txt

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (b01fd8f).