Remove the base_url parameter for diff rendering.

Review Request #4476 — Created Aug. 21, 2013 and submitted

Information

Review Board
master

Reviewers

Remove the base_url parameter for diff rendering.

We used to need this silly base_url parameter for rendering diffs. We
used it for bits of the JavaScript. It's unused now, but we're still
passing it around, so stop doing that.
Unit tests pass.

Went to a few diffs, and didn't see problems.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/diffviewer/templatetags/difftags.py
        reviewboard/diffviewer/views.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/diffviewer/templatetags/difftags.py
        reviewboard/diffviewer/views.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...