Summary

Remove the base_url parameter for diff rendering.

Review Request #4476 — Created Aug. 21, 2013 and submitted Aug. 21, 2013, 11:19 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Remove the base_url parameter for diff rendering.

We used to need this silly base_url parameter for rendering diffs. We
used it for bits of the JavaScript. It's unused now, but we're still
passing it around, so stop doing that.

Testing Done

Unit tests pass.

Went to a few diffs, and didn't see problems.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/diffviewer/templatetags/difftags.py
    reviewboard/diffviewer/views.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/diffviewer/templatetags/difftags.py
    reviewboard/diffviewer/views.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed