Fix up pep-8 issues in some more apps directories.
Review Request #4474 — Created Aug. 21, 2013 and submitted
Fix up pep-8 issues in some more apps directories. This fixes up many of the pep8 issues in the extensions, hostingsvcs, notifications, and reviews directories.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (81 > 79 characters) |
 reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'InvalidChangeNumberError' imported but unused |
reviewbot
|
|
|
'ChangeNumberInUseError' imported but unused |
reviewbot
|
|
|
'ChangeSetError' imported but unused |
reviewbot
|
|
|
'SCMError' imported but unused |
reviewbot
|
|
|
Not sure these parens are necessary. The problem before is that the strings weren't lined up properly. This is really … |
 chipx86
|
|
|
Shouldn't be necessary either. |
chipx86
|
|
|
Or here. I don't see a difference between this and the ones above. Is pep8 complaining about these? |
chipx86
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Mind also changing to assertTrue? |
chipx86
|
|
|
Let's do one per line in this case. |
chipx86
|
|
|
Same. |
chipx86
|
|
|
I don't see this one as an improvement in readability. |
chipx86
|
|
|
One per line? Same with the other changes made in this file. |
chipx86
|
|
|
While here, can you change to self.pk? |
chipx86
|
|
|
Blank line after. |
chipx86
|
|
|
Can you revert the changes to the diff and diff_file_fragment changes for now? This code's all moving around in my … |
chipx86
|
|
|
Mind adding a blank line before this? It doesn't belong in the same logical group as the code dealing with … |
chipx86
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/management/commands/fixreviewcounts.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/datagrids.py reviewboard/hostingsvcs/github.py reviewboard/reviews/management/commands/index.py reviewboard/reviews/ui/base.py reviewboard/reviews/management/commands/fill-database.py reviewboard/hostingsvcs/codebasehq.py reviewboard/extensions/tests.py reviewboard/reviews/models.py reviewboard/reviews/ui/__init__.py reviewboard/extensions/hooks.py reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py reviewboard/reviews/managers.py reviewboard/reviews/tests.py reviewboard/reviews/urls.py reviewboard/reviews/evolutions/file_attachments.py reviewboard/hostingsvcs/service.py reviewboard/extensions/templatetags/rb_extensions.py reviewboard/notifications/email.py reviewboard/reviews/evolutions/change_descriptions.py reviewboard/reviews/evolutions/add_issues_to_comments.py reviewboard/hostingsvcs/tests.py reviewboard/notifications/tests.py reviewboard/reviews/evolutions/localsite.py reviewboard/reviews/admin.py reviewboard/reviews/forms.py reviewboard/extensions/base.py Ignored Files: -
-
-
-
-
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/management/commands/fixreviewcounts.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/datagrids.py reviewboard/hostingsvcs/github.py reviewboard/reviews/management/commands/index.py reviewboard/reviews/ui/base.py reviewboard/reviews/management/commands/fill-database.py reviewboard/hostingsvcs/codebasehq.py reviewboard/extensions/tests.py reviewboard/reviews/models.py reviewboard/reviews/ui/__init__.py reviewboard/extensions/hooks.py reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py reviewboard/reviews/managers.py reviewboard/reviews/tests.py reviewboard/reviews/urls.py reviewboard/reviews/evolutions/file_attachments.py reviewboard/hostingsvcs/service.py reviewboard/extensions/templatetags/rb_extensions.py reviewboard/notifications/email.py reviewboard/reviews/evolutions/change_descriptions.py reviewboard/reviews/evolutions/add_issues_to_comments.py reviewboard/hostingsvcs/tests.py reviewboard/notifications/tests.py reviewboard/reviews/evolutions/localsite.py reviewboard/reviews/admin.py reviewboard/reviews/forms.py reviewboard/extensions/base.py Ignored Files: -
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/management/commands/fixreviewcounts.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/datagrids.py reviewboard/hostingsvcs/github.py reviewboard/reviews/management/commands/index.py reviewboard/reviews/ui/base.py reviewboard/reviews/management/commands/fill-database.py reviewboard/hostingsvcs/codebasehq.py reviewboard/extensions/tests.py reviewboard/reviews/models.py reviewboard/reviews/ui/__init__.py reviewboard/extensions/hooks.py reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py reviewboard/reviews/managers.py reviewboard/reviews/tests.py reviewboard/reviews/urls.py reviewboard/reviews/evolutions/file_attachments.py reviewboard/hostingsvcs/service.py reviewboard/extensions/templatetags/rb_extensions.py reviewboard/notifications/email.py reviewboard/reviews/evolutions/change_descriptions.py reviewboard/reviews/evolutions/add_issues_to_comments.py reviewboard/hostingsvcs/tests.py reviewboard/notifications/tests.py reviewboard/reviews/evolutions/localsite.py reviewboard/reviews/admin.py reviewboard/reviews/forms.py reviewboard/extensions/base.py Ignored Files:
-
-
Not sure these parens are necessary. The problem before is that the strings weren't lined up properly. This is really no different from the strings above.
-
-
-
-
-
-
-
-
-
-
Can you revert the changes to the diff and diff_file_fragment changes for now? This code's all moving around in my change, and will just cause merge headaches.
-
Mind adding a blank line before this? It doesn't belong in the same logical group as the code dealing with local_site.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/management/commands/fixreviewcounts.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/datagrids.py reviewboard/hostingsvcs/github.py reviewboard/reviews/management/commands/index.py reviewboard/reviews/ui/base.py reviewboard/reviews/management/commands/fill-database.py reviewboard/hostingsvcs/codebasehq.py reviewboard/extensions/tests.py reviewboard/reviews/models.py reviewboard/reviews/ui/__init__.py reviewboard/extensions/hooks.py reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py reviewboard/reviews/managers.py reviewboard/reviews/tests.py reviewboard/reviews/urls.py reviewboard/reviews/evolutions/file_attachments.py reviewboard/hostingsvcs/service.py reviewboard/extensions/templatetags/rb_extensions.py reviewboard/notifications/email.py reviewboard/reviews/evolutions/change_descriptions.py reviewboard/reviews/evolutions/add_issues_to_comments.py reviewboard/hostingsvcs/tests.py reviewboard/notifications/tests.py reviewboard/reviews/evolutions/localsite.py reviewboard/reviews/admin.py reviewboard/reviews/forms.py reviewboard/extensions/base.py Ignored Files: -
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/management/commands/fixreviewcounts.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/datagrids.py reviewboard/hostingsvcs/github.py reviewboard/reviews/management/commands/index.py reviewboard/reviews/ui/base.py reviewboard/reviews/management/commands/fill-database.py reviewboard/hostingsvcs/codebasehq.py reviewboard/extensions/tests.py reviewboard/reviews/models.py reviewboard/reviews/ui/__init__.py reviewboard/extensions/hooks.py reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py reviewboard/reviews/managers.py reviewboard/reviews/tests.py reviewboard/reviews/urls.py reviewboard/reviews/evolutions/file_attachments.py reviewboard/hostingsvcs/service.py reviewboard/extensions/templatetags/rb_extensions.py reviewboard/notifications/email.py reviewboard/reviews/evolutions/change_descriptions.py reviewboard/reviews/evolutions/add_issues_to_comments.py reviewboard/hostingsvcs/tests.py reviewboard/notifications/tests.py reviewboard/reviews/evolutions/localsite.py reviewboard/reviews/admin.py reviewboard/reviews/forms.py reviewboard/extensions/base.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/management/commands/fixreviewcounts.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/datagrids.py reviewboard/hostingsvcs/github.py reviewboard/reviews/management/commands/index.py reviewboard/reviews/ui/base.py reviewboard/reviews/management/commands/fill-database.py reviewboard/hostingsvcs/codebasehq.py reviewboard/extensions/tests.py reviewboard/reviews/models.py reviewboard/reviews/ui/__init__.py reviewboard/extensions/hooks.py reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py reviewboard/reviews/managers.py reviewboard/reviews/tests.py reviewboard/reviews/urls.py reviewboard/reviews/evolutions/file_attachments.py reviewboard/hostingsvcs/service.py reviewboard/extensions/templatetags/rb_extensions.py reviewboard/notifications/email.py reviewboard/reviews/evolutions/change_descriptions.py reviewboard/reviews/evolutions/add_issues_to_comments.py reviewboard/hostingsvcs/tests.py reviewboard/notifications/tests.py reviewboard/reviews/evolutions/localsite.py reviewboard/reviews/admin.py reviewboard/reviews/forms.py reviewboard/extensions/base.py Ignored Files: