Fix up pep-8 issues in some more apps directories.

Review Request #4474 — Created Aug. 21, 2013 and submitted

Information

Review Board
master

Reviewers

Fix up pep-8 issues in some more apps directories.

This fixes up many of the pep8 issues in the extensions, hostingsvcs,
notifications, and reviews directories.
Ran unit tests.
Description From Last Updated

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

'ReviewRequest' imported but unused

reviewbotreviewbot

'InvalidChangeNumberError' imported but unused

reviewbotreviewbot

'ChangeNumberInUseError' imported but unused

reviewbotreviewbot

'ChangeSetError' imported but unused

reviewbotreviewbot

'SCMError' imported but unused

reviewbotreviewbot

Not sure these parens are necessary. The problem before is that the strings weren't lined up properly. This is really …

chipx86chipx86

Shouldn't be necessary either.

chipx86chipx86

Or here. I don't see a difference between this and the ones above. Is pep8 complaining about these?

chipx86chipx86

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Mind also changing to assertTrue?

chipx86chipx86

Let's do one per line in this case.

chipx86chipx86

Same.

chipx86chipx86

I don't see this one as an improvement in readability.

chipx86chipx86

One per line? Same with the other changes made in this file.

chipx86chipx86

While here, can you change to self.pk?

chipx86chipx86

Blank line after.

chipx86chipx86

Can you revert the changes to the diff and diff_file_fragment changes for now? This code's all moving around in my …

chipx86chipx86

Mind adding a blank line before this? It doesn't belong in the same logical group as the code dealing with …

chipx86chipx86

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/management/commands/fixreviewcounts.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/datagrids.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/management/commands/fill-database.py
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/extensions/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/ui/__init__.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/tests.py
        reviewboard/reviews/urls.py
        reviewboard/reviews/evolutions/file_attachments.py
        reviewboard/hostingsvcs/service.py
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/notifications/email.py
        reviewboard/reviews/evolutions/change_descriptions.py
        reviewboard/reviews/evolutions/add_issues_to_comments.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/notifications/tests.py
        reviewboard/reviews/evolutions/localsite.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/forms.py
        reviewboard/extensions/base.py
      Ignored Files:
    
    
  2. reviewboard/hostingsvcs/tests.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/management/commands/fixreviewcounts.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/datagrids.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/management/commands/fill-database.py
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/extensions/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/ui/__init__.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/tests.py
        reviewboard/reviews/urls.py
        reviewboard/reviews/evolutions/file_attachments.py
        reviewboard/hostingsvcs/service.py
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/notifications/email.py
        reviewboard/reviews/evolutions/change_descriptions.py
        reviewboard/reviews/evolutions/add_issues_to_comments.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/notifications/tests.py
        reviewboard/reviews/evolutions/localsite.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/forms.py
        reviewboard/extensions/base.py
      Ignored Files:
    
    
  2. reviewboard/reviews/forms.py (Diff revision 1)
     
     
     'ReviewRequest' imported but unused
    
  3. reviewboard/reviews/forms.py (Diff revision 1)
     
     
     'InvalidChangeNumberError' imported but unused
    
  4. reviewboard/reviews/forms.py (Diff revision 1)
     
     
     'ChangeNumberInUseError' imported but unused
    
  5. reviewboard/reviews/forms.py (Diff revision 1)
     
     
     'ChangeSetError' imported but unused
    
  6. reviewboard/reviews/forms.py (Diff revision 1)
     
     
     'SCMError' imported but unused
    
  7. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/management/commands/fixreviewcounts.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/datagrids.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/management/commands/fill-database.py
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/extensions/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/ui/__init__.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/tests.py
        reviewboard/reviews/urls.py
        reviewboard/reviews/evolutions/file_attachments.py
        reviewboard/hostingsvcs/service.py
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/notifications/email.py
        reviewboard/reviews/evolutions/change_descriptions.py
        reviewboard/reviews/evolutions/add_issues_to_comments.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/notifications/tests.py
        reviewboard/reviews/evolutions/localsite.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/forms.py
        reviewboard/extensions/base.py
      Ignored Files:
    
    
  2. reviewboard/hostingsvcs/tests.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/management/commands/fixreviewcounts.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/datagrids.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/management/commands/fill-database.py
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/extensions/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/ui/__init__.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/tests.py
        reviewboard/reviews/urls.py
        reviewboard/reviews/evolutions/file_attachments.py
        reviewboard/hostingsvcs/service.py
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/notifications/email.py
        reviewboard/reviews/evolutions/change_descriptions.py
        reviewboard/reviews/evolutions/add_issues_to_comments.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/notifications/tests.py
        reviewboard/reviews/evolutions/localsite.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/forms.py
        reviewboard/extensions/base.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/codebasehq.py (Diff revision 2)
     
     
     
     
     
    Not sure these parens are necessary. The problem before is that the strings weren't lined up properly. This is really no different from the strings above.
  3. reviewboard/hostingsvcs/codebasehq.py (Diff revision 2)
     
     
     
     
    Shouldn't be necessary either.
  4. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
     
     
     
    Or here. I don't see a difference between this and the ones above. Is pep8 complaining about these?
  5. reviewboard/notifications/tests.py (Diff revision 2)
     
     
    Mind also changing to assertTrue?
  6. reviewboard/reviews/models.py (Diff revision 2)
     
     
     
     
    Let's do one per line in this case.
  7. reviewboard/reviews/models.py (Diff revision 2)
     
     
     
     
  8. reviewboard/reviews/models.py (Diff revision 2)
     
     
     
    I don't see this one as an improvement in readability.
  9. reviewboard/reviews/models.py (Diff revision 2)
     
     
     
    One per line?
    
    Same with the other changes made in this file.
  10. reviewboard/reviews/models.py (Diff revision 2)
     
     
    While here, can you change to self.pk?
  11. reviewboard/reviews/urls.py (Diff revision 2)
     
     
    Blank line after.
  12. reviewboard/reviews/views.py (Diff revision 2)
     
     
     
    Can you revert the changes to the diff and diff_file_fragment changes for now? This code's all moving around in my change, and will just cause merge headaches.
  13. reviewboard/reviews/views.py (Diff revision 2)
     
     
    Mind adding a blank line before this? It doesn't belong in the same logical group as the code dealing with local_site.
  14. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/management/commands/fixreviewcounts.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/datagrids.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/management/commands/fill-database.py
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/extensions/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/ui/__init__.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/tests.py
        reviewboard/reviews/urls.py
        reviewboard/reviews/evolutions/file_attachments.py
        reviewboard/hostingsvcs/service.py
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/notifications/email.py
        reviewboard/reviews/evolutions/change_descriptions.py
        reviewboard/reviews/evolutions/add_issues_to_comments.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/notifications/tests.py
        reviewboard/reviews/evolutions/localsite.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/forms.py
        reviewboard/extensions/base.py
      Ignored Files:
    
    
  2. reviewboard/hostingsvcs/tests.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/management/commands/fixreviewcounts.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/datagrids.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/management/commands/fill-database.py
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/extensions/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/ui/__init__.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/tests.py
        reviewboard/reviews/urls.py
        reviewboard/reviews/evolutions/file_attachments.py
        reviewboard/hostingsvcs/service.py
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/notifications/email.py
        reviewboard/reviews/evolutions/change_descriptions.py
        reviewboard/reviews/evolutions/add_issues_to_comments.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/notifications/tests.py
        reviewboard/reviews/evolutions/localsite.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/forms.py
        reviewboard/extensions/base.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c238c58).
Loading...