Polish up some styling in the diff viewer.
Review Request #4460 — Created Aug. 15, 2013 and submitted
Polish up some styling in the diff viewer.
First, the text above the diff index is aligned. There's now a
consistent margin for that whole section, meaning none of the contents
will stick out of the bounds.
The loading spinner and icons in the index now take up the same amount
of space, preventing little jumps when loading items.
The selection border for chunks and diff headers is once again properly
aligned. This broke when shadows were put back on the diff boxes.
Deleted files, binary files, and unchanged files now have slightly nicer
styles. The text contents ("This file has been deleted," for example)
are no longer bunched up against the sides. There's now some padding,
leaving breathing room.
In the case of deleted files, the background is now reddish (same as the
removed lines in standard diffs), instead of blue.
In the case of unchanged files, the background is white.
In the case of whitespace-only changes, the background is that of
replaced lines.
And finally, the errors are a little nicer. There's an error icon, a
nicer header, and some helpful text after the error saying how to
contact support. The traceback, if any, now has a border and white
background.
Tested all this in Chrome and Firefox.
| Description | From | Last Updated |
|---|---|---|
|
These need to be marked for translation. |
 david
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/diffviewer.less reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js
-
-
reviewboard/templates/diffviewer/diff_fragment_error.html (Diff revision 1) These need to be marked for translation.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/diffviewer.less reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/diffviewer.less reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/diffviewer.less reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js