Summary

Fix S3 querystring auth.

Review Request #4457 — Created Aug. 14, 2013 and submitted Aug. 14, 2013, 5:52 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix S3 querystring auth.

The boto-based S3 backed defaults to using query-string authentication, which
causes the URL to expire after a while. This is meant to prevent hot-linking,
but in our case, it's easy to have it not quite sync up with our caching,
ending up with a cached link which is then expired. This change turns off
querystring auth in the storage backend.

Testing Done

Configured my devserver to use S3, and uploaded a file. Checked and saw that
the relevant URLs generated no longer contained the various querystring
parameters.

Issues

Description	From	Last Updated
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 14, 2013, 2:37 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 14, 2013, 2:37 p.m.
I suspect the reason the others blew up was due to str vs. unicode. You shouldn't need to cast to …	chipx86	Aug. 14, 2013, 5:35 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 14, 2013, 5:40 p.m.
Col: 28 E241 multiple spaces after ':'	reviewbot	Aug. 14, 2013, 5:40 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/siteconfig.py
  Ignored Files:

reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/siteconfig.py
  Ignored Files:

reviewboard/admin/siteconfig.py (Diff revision 1)

The issue has been resolved. Show all issues

I suspect the reason the others blew up was due to str vs. unicode. You shouldn't need to cast to bool.

Diff:

Revision 2 (+3)

Show changes

reviewboard/admin/siteconfig.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/siteconfig.py
  Ignored Files:

reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 28
 E241 multiple spaces after ':'
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/siteconfig.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (80118f7).