Fix S3 querystring auth.
Review Request #4457 — Created Aug. 14, 2013 and submitted
Fix S3 querystring auth. The boto-based S3 backed defaults to using query-string authentication, which causes the URL to expire after a while. This is meant to prevent hot-linking, but in our case, it's easy to have it not quite sync up with our caching, ending up with a cached link which is then expired. This change turns off querystring auth in the storage backend.
Configured my devserver to use S3, and uploaded a file. Checked and saw that the relevant URLs generated no longer contained the various querystring parameters.
| Description | From | Last Updated |
|---|---|---|
|
Col: 28 E241 multiple spaces after ':' |
 reviewbot
|
|
|
Col: 28 E241 multiple spaces after ':' |
reviewbot
|
|
|
I suspect the reason the others blew up was due to str vs. unicode. You shouldn't need to cast to … |
 chipx86
|
|
|
Col: 28 E241 multiple spaces after ':' |
reviewbot
|
|
|
Col: 28 E241 multiple spaces after ':' |
reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/siteconfig.py Ignored Files:
-
-
reviewboard/admin/siteconfig.py (Diff revision 1) I suspect the reason the others blew up was due to str vs. unicode. You shouldn't need to cast to bool.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/siteconfig.py Ignored Files: -
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/siteconfig.py Ignored Files: