Add machinery for internationalizing our javascript.
Review Request #4452 — Created Aug. 13, 2013 and submitted
Add machinery for internationalizing our javascript. This adds the javascript catalog view, and the random bits of plumbing we'll need to localize all the strings in our javascript code. It does not actually mark any strings in the javascript code--that's coming in a future change.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py reviewboard/urls.py Ignored Files: reviewboard/templates/base.html .gitignore
-
-
reviewboard/templates/base.html (Diff revision 1) We can nuke the type="text/javascript". All browsers assume this by default, and the new best practices are to just use that assumption and reduce the noise/size of files.
-
reviewboard/urls.py (Diff revision 1) I think we want to be lazy here with how we load the serial. Many requests will never need this, yet processes will spin up and we'll walk the filesystem (potentially slow with things like EBS). Instead, I'd suggest cached_javascript_catalog generate and cache a serial on first use.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py reviewboard/urls.py Ignored Files: reviewboard/templates/base.html .gitignore
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py reviewboard/urls.py Ignored Files: reviewboard/templates/base.html .gitignore