Add utilities for the javascript message catalog.
Review Request #4451 — Created Aug. 13, 2013 and submitted
Add utilities for the javascript message catalog. Django has a view for serving a javascript implementation of gettext and a message catalog for the desired language. This view recomputes everything every time it's fetched, which is kind of terrible. This change adds some utilities for caching the data in a way which works like our old media serial did.
Used this in conjunction with some mocked-up javascript i18n files for different languages and saw it generate and use good cache keys.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files:
-
-
djblets/util/misc.py (Diff revision 1) We should have a try/except here, and log any failed attempts. ImportErrors can easily masquerade as other, confusing failures.
-
-
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files:
Change Summary:
Generate the locale serials from within the view and cache them.
Diff: |
Revision 3 (+55) |
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files:
-
-
djblets/util/views.py (Diff revision 3) This should be at the top of the function, with a blank line after.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/util/views.py djblets/util/misc.py Ignored Files: