Summary

Add utilities for the javascript message catalog.

Review Request #4451 — Created Aug. 13, 2013 and submitted Aug. 14, 2013, 5:32 p.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Add utilities for the javascript message catalog.

Django has a view for serving a javascript implementation of gettext and a
message catalog for the desired language. This view recomputes everything every
time it's fetched, which is kind of terrible. This change adds some utilities
for caching the data in a way which works like our old media serial did.

Testing Done

Used this in conjunction with some mocked-up javascript i18n files for
different languages and saw it generate and use good cache keys.

Issues

Description	From	Last Updated
We should have a try/except here, and log any failed attempts. ImportErrors can easily masquerade as other, confusing failures.	chipx86	Aug. 14, 2013, 12:39 p.m.
Blank line before.	chipx86	Aug. 14, 2013, 12:37 p.m.
""" on the next line.	chipx86	Aug. 14, 2013, 12:37 p.m.
This should be at the top of the function, with a blank line after.	chipx86	Aug. 14, 2013, 1:38 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

djblets/util/misc.py (Diff revision 1)

The issue has been resolved. Show all issues

We should have a try/except here, and log any failed attempts. ImportErrors can easily masquerade as other, confusing failures.

djblets/util/misc.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before.
```
djblets/util/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
""" on the next line.
```

Diff:

Revision 2 (+51)

Show changes

	djblets/util/misc.py
	djblets/util/views.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

Change Summary:

Generate the locale serials from within the view and cache them.

Diff:

Revision 3 (+55)

Show changes

	djblets/util/misc.py
	djblets/util/views.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

djblets/util/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should be at the top of the function, with a blank line after.
```

Diff:

Revision 4 (+56)

Show changes

	djblets/util/misc.py
	djblets/util/views.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/util/views.py
    djblets/util/misc.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (cac534e).