Make use of Beanstalk's new blob API for fetching files.

Review Request #4438 — Created Aug. 13, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Make use of Beanstalk's new blob API for fetching files.

Beanstalk kindly added a blob API for us so that we could easily fetch
the contents of files without need the base_commit_id. That gives our
users the choice to continue using older versions of RBTools or to
upload a standard 'git diff' if they choose.

We now use the new blob API when fetching the raw contents of a file, or
when we need to check file existence without having a base_commit_id.

Unit tests were updated to handle the new flows, and to not expect
errors in the case of Git + no base commit ID.
Tested manually with some repositories I had set up.

Unit tests pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/hostingsvcs/tests.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/hostingsvcs/tests.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...