Improve i18n a bit.

Review Request #4426 — Created Aug. 12, 2013 and submitted

Information

Review Board
master

Reviewers

Improve i18n a bit.

I'm working on integrating the Italian localization that we recieved at
https://reviews.reviewboard.org/r/4298/

There are a few things that were getting in the way here. We have some old i18n
scripts in contrib/ which mostly work, but should be removed in favor of the
django-admin.py versions. The django-admin.py version of makemessages was
erroring out in a couple places where we were using positional format strings
with multiple arguments, instead of parameter names. I've fixed these up.

There are also several strings which aren't marked for translation. A lot of
these are likely coming from javascript, but one that was immediately obvious
was the dashboard's sidebar.
Integrated the contributed Italian localization files, and ran
compilemessages. Set my browser to prefer Italian, and saw that most of
the UI was now translated. Neat.
Description From Last Updated

Col: 13 E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

For readability, can you put the "`patch` returned" part on the next line?

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/forms.py
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
        reviewboard/templates/reviews/dashboard.html
    
    
  2. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
    Col: 13
     E123 closing bracket does not match indentation of opening bracket's line
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/forms.py
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
        reviewboard/templates/reviews/dashboard.html
    
    
  2. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/forms.py
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
        reviewboard/templates/reviews/dashboard.html
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/forms.py
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
        reviewboard/templates/reviews/dashboard.html
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/diffviewer/diffutils.py (Diff revision 2)
     
     
    For readability, can you put the "`patch` returned" part on the next line?
  3. reviewboard/scmtools/forms.py (Diff revision 2)
     
     
     
     
     
    Cute. Shame xgettext isn't smarter than that.
  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/forms.py
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
        reviewboard/templates/reviews/dashboard.html
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/forms.py
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
        reviewboard/templates/reviews/dashboard.html
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (ca18021).
Loading...