Summary

Improve i18n a bit.

Review Request #4426 — Created Aug. 12, 2013 and submitted Aug. 13, 2013, 2:12 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Improve i18n a bit.

I'm working on integrating the Italian localization that we recieved at
https://reviews.reviewboard.org/r/4298/

There are a few things that were getting in the way here. We have some old i18n
scripts in contrib/ which mostly work, but should be removed in favor of the
django-admin.py versions. The django-admin.py version of makemessages was
erroring out in a couple places where we were using positional format strings
with multiple arguments, instead of parameter names. I've fixed these up.

There are also several strings which aren't marked for translation. A lot of
these are likely coming from javascript, but one that was immediately obvious
was the dashboard's sidebar.

Testing Done

Integrated the contributed Italian localization files, and ran
compilemessages. Set my browser to prefer Italian, and saw that most of
the UI was now translated. Neat.

Issues

Description	From	Last Updated
Col: 13 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Aug. 12, 2013, 5:12 p.m.
For readability, can you put the "`patch` returned" part on the next line?	chipx86	Aug. 12, 2013, 10:06 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/forms.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/dashboard.html

reviewboard/diffviewer/diffutils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E123 closing bracket does not match indentation of opening bracket's line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/forms.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/dashboard.html

Diff:

Revision 2 (+23 -14)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/scmtools/forms.py
	reviewboard/templates/reviews/dashboard.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/forms.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/dashboard.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/forms.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/dashboard.html

reviewboard/diffviewer/diffutils.py (Diff revision 2)
The issue has been resolved. Show all issues
```
For readability, can you put the "`patch` returned" part on the next line?
```

reviewboard/scmtools/forms.py (Diff revision 2)

Cute. Shame xgettext isn't smarter than that.

Diff:

Revision 3 (+24 -14)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/scmtools/forms.py
	reviewboard/templates/reviews/dashboard.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/forms.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/dashboard.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/forms.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/dashboard.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ca18021).