Fix several issues found throughout the test suite.

Review Request #4425 — Created Aug. 12, 2013 and submitted

Information

RBTools
master

Reviewers

Fix several issues found throughout the test suite.

The test suite has been broken for a while, due to a variety of issues,
ranging from lack of valid configuration for certain tools to bad temp
directories, to path mismatch issues on MacOS X.

This fixes all the unit tests, getting us back to 100% test coverage,
where we are never allowed to leave again.
All unit tests pass.
Description From Last Updated

These should be grouped with the stdlib modules.

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/utils/testbase.py
        rbtools/clients/tests.py
        rbtools/api/errors.py
        rbtools/utils/filesystem.py
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        rbtools/utils/testbase.py
        rbtools/clients/tests.py
        rbtools/api/errors.py
        rbtools/utils/filesystem.py
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
david
  1. 
      
  2. rbtools/clients/tests.py (Diff revision 1)
     
     
    hgsubversion =
    
    ??
    1. That looks weird, but is actually recommended if hgsubversion is in the PYTHONPATH. Their docs say that a blank value causes it to look up in the path.
    2. Can you add a comment to that effect?
  3. rbtools/utils/testbase.py (Diff revision 1)
     
     
     
     
     
    Show all issues
    These should be grouped with the stdlib modules.
  4. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/utils/testbase.py
        rbtools/clients/tests.py
        rbtools/api/errors.py
        rbtools/utils/filesystem.py
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        rbtools/utils/testbase.py
        rbtools/clients/tests.py
        rbtools/api/errors.py
        rbtools/utils/filesystem.py
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/utils/testbase.py
        rbtools/clients/tests.py
        rbtools/api/errors.py
        rbtools/utils/filesystem.py
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        rbtools/utils/testbase.py
        rbtools/clients/tests.py
        rbtools/api/errors.py
        rbtools/utils/filesystem.py
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...